Dev rc/v3 bug fix #785
Merged
Dev rc/v3 bug fix #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v3 #785 +/- ##
==========================================
- Coverage 50.23% 49.62% -0.62%
==========================================
Files 598 598
Lines 37186 37212 +26
==========================================
- Hits 18682 18466 -216
- Misses 18504 18746 +242 ☔ View full report in Codecov by Sentry. |
wahln
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Thanks for looking into it. Not entirely sure about the axis permutation fix, as it also needs to be seen in the bigger context of the writeCube function. Please make sure that this is consistent with what would be imported in another platform (e.g. 3D Slicer or MITK) and that the reimport in matRad works out (maybe the tests don't cover this situation yet).
wahln
approved these changes
Nov 7, 2024
acsevillam
pushed a commit
to acsevillam/matRad
that referenced
this pull request
Oct 21, 2025
* Minor bug, update cube dimension in writeMHD to make dimension permeutation effective * Minor bug fix, misisng matRad_cfg * Modify use of cube permutation and transformation matrix * Add permutation to vtk writer --------- Co-authored-by: Niklas Wahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug fixing in:
matRad_writeMHDmatRad_StfGenratorBase