Skip to content

Conversation

@ahmadnish
Copy link
Contributor

Hello :), so I wanted to instantiate pull requesting again with a minor fix now that I am working with matRad (actually, pyRadPlan) more often. I noticed that example2 tries to assign titles to the plotSliceWrapper, but they were getting masked by the axis settings.

@wahln
Copy link
Contributor

wahln commented Apr 4, 2025

Thanks for that.
I will not merge this onto master. Instead, as soon as @SimonaFa has finished her refactor of the plotSliceWrapper into plotSlice in #818, I will merge your developments into #818 and merge everything into dev.

@github-actions
Copy link

This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR.

@github-actions github-actions bot added the stale Automatic label for stale issues label May 25, 2025
@codecov
Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d5bd5bb) to head (3c34966).
Report is 9 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #831   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wahln
Copy link
Contributor

wahln commented Jun 23, 2025

@SimonaFa since I just merged #818 could you check this pull request by @ahmadnish and see if we need to make some adaptations?

@github-actions github-actions bot removed the stale Automatic label for stale issues label Jun 24, 2025
@github-actions
Copy link

This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR.

@github-actions github-actions bot added the stale Automatic label for stale issues label Jul 24, 2025
@wahln
Copy link
Contributor

wahln commented Jul 24, 2025

This has been translated to the new matRad_plotSlice function (which uses key-value argument pairs instead of the long sequence of optional arguments) and merged onto dev in #854.
Since @SimonaFa used your implementation as a basis, I have added you as a co-author on the squashed merge commit. Will close this PR.

@wahln wahln closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Automatic label for stale issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants