Skip to content

Conversation

@wahln
Copy link
Contributor

@wahln wahln commented Apr 4, 2025

This adds a check for valid classes in our availability gathering functions for Dose Engines, STF Generators, Sceario Models and Biological Models.

This is particularly helpful during development when class code is edited, as this will cause the metaclass handles to become invalid such that the modified class will no longer be identified as available.

@wahln wahln requested a review from JenHardt April 4, 2025 09:33
@wahln wahln requested a review from Copilot April 4, 2025 12:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • matRad/bioModels/matRad_BiologicalModel.m: Language not supported
  • matRad/doseCalc/+DoseEngines/@matRad_DoseEngineBase/getAvailableEngines.m: Language not supported
  • matRad/scenarios/matRad_ScenarioModel.m: Language not supported
  • matRad/steering/matRad_StfGeneratorBase.m: Language not supported

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0c53355) to head (101566a).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@    Coverage Diff     @@
##   dev   #833   +/-   ##
==========================
==========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Test Results

  3 files  ±0    3 suites  ±0   41m 45s ⏱️ +10s
282 tests ±0  282 ✅ ±0  0 💤 ±0  0 ❌ ±0 
942 runs  ±0  937 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 101566a. ± Comparison against base commit 0c53355.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Code Coverage

Package Line Rate Health
coverage Package 1 52%
Summary 52% (10204 / 19473)

@wahln wahln merged commit e1e507c into dev Apr 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants