Skip to content

Conversation

@JenHardt
Copy link
Contributor

@JenHardt JenHardt commented Oct 2, 2025

In MATLAB ONLINE the gui window was to large

added a switch to check if it is called from matlab online or not, the easiest way to check this is with isunix as matlab online runs with unix. Without this switch the initial GUI window can be a little bit smaller than fullscreen when run from matlab Desktop

added a switch to check if it is called from matlab online or not, the easiest way to check this is with isunix as matlab online runs with unix. Without this switch the initial GUI window can be a little bit smaller than fullscreen when run from matlab Desktop
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.82%. Comparing base (dddf27c) to head (7b7075d).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
matRad/gui/matRad_MainGUI.m 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #871      +/-   ##
==========================================
- Coverage   53.85%   53.82%   -0.04%     
==========================================
  Files         308      308              
  Lines       19947    19949       +2     
==========================================
- Hits        10742    10737       -5     
- Misses       9205     9212       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wahln
Copy link
Contributor

wahln commented Oct 2, 2025

Okay, but what happens if you just run on a mac or linux system then (without being in MATLAB online?)

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results

    3 files  ±0      3 suites  ±0   44m 27s ⏱️ +27s
  318 tests ±0    318 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 050 runs  ±0  1 045 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 7b7075d. ± Comparison against base commit dddf27c.

@JenHardt
Copy link
Contributor Author

JenHardt commented Oct 2, 2025

Okay, but what happens if you just run on a mac or linux system then (without being in MATLAB online?)

this onscreen option ensures that the gui window fits within the screen so it might initaliy be slightly to small, and not entierly full screen if it is used outside of Online. This is also how the GUI looks from octavae

@wahln wahln merged commit 84bea14 into e0404:dev Oct 2, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants