Skip to content

Adds tests for the updated JavaScript kernel #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

mishushakov
Copy link
Member

  • Adds tests for ESM imports, top-level async/await, promise resolution

@mishushakov mishushakov self-assigned this May 28, 2025
@mishushakov mishushakov added the improvement Improvement for current functionality label May 28, 2025
@mishushakov mishushakov enabled auto-merge (squash) May 28, 2025 17:29
Copy link
Contributor

@0div 0div left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nice to have: one or two tests around esoteric TS syntax just to see how it behaves and if the version we use is in line with them.

@mishushakov mishushakov merged commit 85cac91 into main May 28, 2025
4 checks passed
@mishushakov mishushakov deleted the added-js-kernel-tests branch May 28, 2025 17:34
@mishushakov
Copy link
Member Author

I doubt the LLMs will be generating anything like this, after all it makes it harder to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants