Skip to content

ISSUE-167: update log for configuration #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DongbinCheng merged 1 commit into from
Apr 7, 2026
Merged

ISSUE-167: update log for configuration #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/app_util/AppInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,18 @@ void AppInfo::init(uint64_t clusterConfersion, NodeId nodeId, const ClusterInfo
appInfo.mMyNodeId = nodeId;
appInfo.mMyClusterId = clusterInfo.getClusterId();
appInfo.mAllClusterInfo[nodeId] = clusterInfo;

std::string clusterInfoString = appInfo.getMyClusterInfo().to_string();
getGauge("configuration_version", {{"address", clusterInfoString}}).set(appInfo.mClusterVersion);

SPDLOG_INFO("Global settings: "
"app.clusterconfversion={}, "
"app.clusterid={}, "
"app.nodeid={}",
"app.clusterconf={}",
appInfo.mClusterVersion,
appInfo.mMyClusterId,
appInfo.mMyNodeId,
clusterInfoString);
}
} /// namespace gringofts::app
12 changes: 6 additions & 6 deletions src/app_util/AppInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ class AppInfo final {
static void setClusterInfo(uint64_t clusterVersion, NodeId nodeId, const ClusterInfo &clusterInfo) {
assert(getMyClusterId() == clusterInfo.getClusterId()); // cluster id cannot be changed
assert(clusterVersion > getClusterVersion()); // version should be increased
SPDLOG_INFO("AppInfo receive reconfiguration, selfId: {}, version: {}, cluster configuration: {}",
nodeId, clusterVersion, clusterInfo.to_string());
SPDLOG_INFO("AppInfo's old reconfiguration, selfId: {}, version: {}, cluster configuration: {}",
getMyNodeId(), getClusterVersion(), getMyClusterInfo().to_string());
SPDLOG_INFO("AppInfo receive reconfiguration, selfId: {}, version: {}, cluster configuration: {}",
nodeId, clusterVersion, clusterInfo.to_string());
if (nodeId == kUnknownNodeId) {
SPDLOG_INFO("node id is unknown({}). exiting...", nodeId);
assert(0);
Expand All @@ -104,16 +104,16 @@ class AppInfo final {
const auto& initialRoleMap = getMyClusterInfo().getAllInitialRoles();
const auto iter = initialRoleMap.find(getMyNodeId());
if (iter == initialRoleMap.end()) {
SPDLOG_INFO("cluster is 0, and node default role not set, will start with follower role");
SPDLOG_INFO("node default role not set, will start with follower role");
role = raft::RaftRole::Follower;
} else if (iter->second == protos::InitialRaftRole::Learner) {
SPDLOG_INFO("cluster is 0, and node is learner, will start with learner role");
SPDLOG_INFO("node is learner, will start with learner role");
role = raft::RaftRole::Learner;
} else if (iter->second == protos::InitialRaftRole::PreFollower) {
SPDLOG_INFO("cluster is 0, and node is pre-follower, will start with pre-follower role");
SPDLOG_INFO("node is pre-follower, will start with pre-follower role");
role = raft::RaftRole::PreFollower;
} else {
SPDLOG_INFO("cluster is 0, and node is voter, will start with follower role");
SPDLOG_INFO("node is voter, will start with follower role");
role = raft::RaftRole::Follower;
}
return role;
Expand Down
Loading