Skip to content

Update blk_size from 1K to 4K to align with the physical sector size of HDDs #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented May 14, 2025

This change also supports larger blob sizes due to the limitation of max_blks_per_blkid

@Besroy Besroy changed the title [TEST] test 4K blk for all uts Update blk_size from 1K to 4K to align with the physical sector size of HDDs May 16, 2025
…of HDDs.

This change also supports larger blob sizes due to the limitation of max_blks_per_blkid
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.27%. Comparing base (1746bcc) to head (19d4c59).
Report is 71 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   63.15%   59.27%   -3.89%     
==========================================
  Files          32       33       +1     
  Lines        1900     3045    +1145     
  Branches      204      360     +156     
==========================================
+ Hits         1200     1805     +605     
- Misses        600     1047     +447     
- Partials      100      193      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaoxichen xiaoxichen merged commit 1f306ed into eBay:main May 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants