Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Conversation

@agliga
Copy link
Contributor

@agliga agliga commented Dec 9, 2024

#2321

Description

  • In order to make it so we dont upload compiled files to the CDN I changed the loading portion of our modules to load modules asynchronously.
  • Changed model-viewer, highcharts, and shaka-player to load asynchronously.
  • The changes to package.json, and prettier are needed because we introduced a nested node_modules directory

Context

  • Part of the issue is we need to support lasso and webpack async. These load modules asynchronously very differently.
  • We added a "fake" node_module directory where we load a module using import() if its vite or webpack, but if its lasso we load it using lassoLoader
  • The reason why there are multiple modules is mainly for bundling purposes. These will all be indexed properly.
  • These also need to be tested in a prerelase to verify that this is working fine is all various types of apps.

note I had to disable a highcharts test because it was not finding the text correctly.

References

#2305

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 706b79a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor Author

agliga commented Dec 9, 2024

Should be ready to go. Tested it with various applications

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed offline, looks good!

@agliga agliga merged commit 9c308b4 into 14.6.0 Dec 20, 2024
5 checks passed
@agliga agliga deleted the async-loading branch December 20, 2024 16:21
This was referenced Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants