Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Conversation

@agliga
Copy link
Contributor

@agliga agliga commented Feb 28, 2025

Description

  • Swapped deprecated event charCode and keyCode to use key

Context

For tests, I updated "(Space key)" to be just " "

References

#2431

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: aae1c3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! Just one question and then I'll approve

@agliga agliga changed the base branch from master to 15.2.0 February 28, 2025 19:18
@agliga agliga merged commit 9bd9d23 into 15.2.0 Feb 28, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
This was referenced Mar 25, 2025
@agliga agliga deleted the event-utils branch March 31, 2025 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants