Try re-enabling the formatNumber rounding tests with 64-bit Windows builds (#319)

* Try re-enabling the formatNumber rounding tests with 64-bit Windows builds.
* Turn on LDC tests also.
* Narrow the set of failing formatNumber tests on Windows.
* Update the failing value test.
* Remove the failing test from the common set.
* Turn off LDC unit tests.

Author: jondegenhardt

.github/workflows/d.yml

@@ -34,7 +34,8 @@ jobs:
           make clean
 
       - name: make unittest
-        # Currently, only run unit tests on DMD. LDC has failures due to numeric formatting.
+        # Currently, only run unit tests on DMD. LDC has failures in tsv-sample due
+        # to minor descrepancies in printed random numbers.
         if: ${{ startsWith(matrix.dc, 'dmd') }}
         shell: bash
         run: |

common/src/tsv_utils/common/numerics.d

@@ -209,36 +209,45 @@ unittest  // formatNumber unit tests
     assert(formatNumber(1234567891234.0, 0) == "1234567891234");
     assert(formatNumber(1234567891234.0, 1) == "1234567891234");
 
-    // Test round off cases
+    /* Test round off cases. Note: These tests will not pass on Windows 32-bit builds.
+     * Use the -m64 flag on Windows to get a 64-bit build.
+     *
+     * Note: The first test case does not generate the correct result on Windows
+     * 64-bit builds. The current Windows result is included both for documentation
+     * and to provide an alert if the correct result starts getting populated. Both
+     * formatNumber and the underlying format call are included.
+     */
     version(Windows)
     {
-        /* Round-off cases don't work properly on Windows. They truncate rather than
-         * round. May be a DMD specific Windows bug, not clear.
-         */
+        // Incorrect
+        assert(format("%.*f", 0, 0.6) == "0");
+        assert(formatNumber(0.6, 0) == "0");
     }
     else
     {
+        assert(format("%.*f", 0, 0.6) == "1");
         assert(formatNumber(0.6, 0) == "1");
-        assert(formatNumber(0.6, 1) == "0.6");
-        assert(formatNumber(0.06, 0) == "0");
-        assert(formatNumber(0.06, 1) == "0.1");
-        assert(formatNumber(0.06, 2) == "0.06");
-        assert(formatNumber(0.06, 3) == "0.06");
-        assert(formatNumber(9.49999, 0) == "9");
-        assert(formatNumber(9.49999, 1) == "9.5");
-        assert(formatNumber(9.6, 0) == "10");
-        assert(formatNumber(9.6, 1) == "9.6");
-        assert(formatNumber(99.99, 0) == "100");
-        assert(formatNumber(99.99, 1) == "100");
-        assert(formatNumber(99.99, 2) == "99.99");
-        assert(formatNumber(9999.9996, 3) == "10000");
-        assert(formatNumber(9999.9996, 4) == "9999.9996");
-        assert(formatNumber(99999.99996, 4) == "100000");
-        assert(formatNumber(99999.99996, 5) == "99999.99996");
-        assert(formatNumber(999999.999996, 5) == "1000000");
-        assert(formatNumber(999999.999996, 6) == "999999.999996");
     }
 
+    assert(formatNumber(0.6, 1) == "0.6");
+    assert(formatNumber(0.06, 0) == "0");
+    assert(formatNumber(0.06, 1) == "0.1");
+    assert(formatNumber(0.06, 2) == "0.06");
+    assert(formatNumber(0.06, 3) == "0.06");
+    assert(formatNumber(9.49999, 0) == "9");
+    assert(formatNumber(9.49999, 1) == "9.5");
+    assert(formatNumber(9.6, 0) == "10");
+    assert(formatNumber(9.6, 1) == "9.6");
+    assert(formatNumber(99.99, 0) == "100");
+    assert(formatNumber(99.99, 1) == "100");
+    assert(formatNumber(99.99, 2) == "99.99");
+    assert(formatNumber(9999.9996, 3) == "10000");
+    assert(formatNumber(9999.9996, 4) == "9999.9996");
+    assert(formatNumber(99999.99996, 4) == "100000");
+    assert(formatNumber(99999.99996, 5) == "99999.99996");
+    assert(formatNumber(999999.999996, 5) == "1000000");
+    assert(formatNumber(999999.999996, 6) == "999999.999996");
+
     /* Turn off precision, the 'human readable' style.
      * Note: Remains o if both are zero (first test). If it becomes desirable to support
      * turning it off when for the precision equal zero case the simple extension is to
@@ -314,42 +323,51 @@ unittest  // formatNumber unit tests
     assert(formatNumber(-1234567891234.0, 0) == "-1234567891234");
     assert(formatNumber(-1234567891234.0, 1) == "-1234567891234");
 
-    // Test round off cases
+    /* Test round off cases with negative numbers. Note: These tests will not pass
+     * on Windows 32-bit builds. Use the -m64 flag on Windows to get a 64-bit build.
+     *
+     * Note: The first test case does not generate the correct result on Windows
+     * 64-bit builds. The current Windows result is included both for documentation
+     * and to provide an alert if the correct result starts getting populated. Both
+     * formatNumber and the underlying format call are included.
+     */
     version(Windows)
     {
-        /* Round-off cases don't work properly on Windows. They truncate rather than
-         * round. May be a DMD specific Windows bug, not clear.
-         */
+        // Incorrect
+        assert(format("%.*f", 0, -0.6) == "-0");
+        assert(formatNumber(-0.6, 0) == "-0");
     }
     else
     {
+        assert(format("%.*f", 0, -0.6) == "-1");
         assert(formatNumber(-0.6, 0) == "-1");
-        assert(formatNumber(-0.6, 1) == "-0.6");
-        assert(formatNumber(-0.06, 0) == "-0");
-        assert(formatNumber(-0.06, 1) == "-0.1");
-        assert(formatNumber(-0.06, 2) == "-0.06");
-        assert(formatNumber(-0.06, 3) == "-0.06");
-        assert(formatNumber(-9.49999, 0) == "-9");
-        assert(formatNumber(-9.49999, 1) == "-9.5");
-        assert(formatNumber(-9.6, 0) == "-10");
-        assert(formatNumber(-9.6, 1) == "-9.6");
-        assert(formatNumber(-99.99, 0) == "-100");
-        assert(formatNumber(-99.99, 1) == "-100");
-        assert(formatNumber(-99.99, 2) == "-99.99");
-        assert(formatNumber(-9999.9996, 3) == "-10000");
-        assert(formatNumber(-9999.9996, 4) == "-9999.9996");
-        assert(formatNumber(-99999.99996, 4) == "-100000");
-        assert(formatNumber(-99999.99996, 5) == "-99999.99996");
-        assert(formatNumber(-999999.999996, 5) == "-1000000");
-        assert(formatNumber(-999999.999996, 6) == "-999999.999996");
-
-        assert(formatNumber!(double, 0)(-999.123412, 0) == "-999");
-        assert(formatNumber!(double, 0)(-999.123412, 1) == "-1e+03");
-        assert(formatNumber!(double, 0)(-999.123412, 2) == "-1e+03");
-        assert(formatNumber!(double, 0)(-999.123412, 3) == "-999");
-        assert(formatNumber!(double, 0)(-999.123412, 4) == "-999.1");
     }
 
+    assert(formatNumber(-0.6, 1) == "-0.6");
+    assert(formatNumber(-0.06, 0) == "-0");
+    assert(formatNumber(-0.06, 1) == "-0.1");
+    assert(formatNumber(-0.06, 2) == "-0.06");
+    assert(formatNumber(-0.06, 3) == "-0.06");
+    assert(formatNumber(-9.49999, 0) == "-9");
+    assert(formatNumber(-9.49999, 1) == "-9.5");
+    assert(formatNumber(-9.6, 0) == "-10");
+    assert(formatNumber(-9.6, 1) == "-9.6");
+    assert(formatNumber(-99.99, 0) == "-100");
+    assert(formatNumber(-99.99, 1) == "-100");
+    assert(formatNumber(-99.99, 2) == "-99.99");
+    assert(formatNumber(-9999.9996, 3) == "-10000");
+    assert(formatNumber(-9999.9996, 4) == "-9999.9996");
+    assert(formatNumber(-99999.99996, 4) == "-100000");
+    assert(formatNumber(-99999.99996, 5) == "-99999.99996");
+    assert(formatNumber(-999999.999996, 5) == "-1000000");
+    assert(formatNumber(-999999.999996, 6) == "-999999.999996");
+
+    assert(formatNumber!(double, 0)(-999.123412, 0) == "-999");
+    assert(formatNumber!(double, 0)(-999.123412, 1) == "-1e+03");
+    assert(formatNumber!(double, 0)(-999.123412, 2) == "-1e+03");
+    assert(formatNumber!(double, 0)(-999.123412, 3) == "-999");
+    assert(formatNumber!(double, 0)(-999.123412, 4) == "-999.1");
+
     // Default number printing
     assert(formatNumber(-1.2) == "-1.2");
     assert(formatNumber(-12.3) == "-12.3");