Skip to content

Conversation

@KevOutIngs
Copy link

Feat: Enable translation. Some are still missing though

@JeanTheFungle
Copy link

this pull add translation ? seem good

@KevOutIngs
Copy link
Author

KevOutIngs commented Oct 23, 2023

this pull add translation ? seem

Yes, it enables translation through the .resx file.

I think a lot of strings are still missing.

Sorry, I forgot to add some information about it.

  • It reads the language file from AmongUS inside the LocalLow folder and sets it for the mod.
  • To add a new file, you have to enable it once in the LocalizationManager: 'es': 'Spanish' ('es' would be the start of the translation file es.resx, and 'Spanish' is the string that AmongUS uses to set the language in the game).
    Unfortunately, if users change the language of the game, they will have to restart their game.

I wasn't able to test every string I added for translation, so some of them may have been typed incorrectly, and it could show "Key Not Found" to the users.

@JeanTheFungle
Copy link

ah maybe i can use it for my mod :) i'am going credit. anyways just if they change language of the game why they need to restart you must implement something but its good

@KevOutIngs
Copy link
Author

ah maybe i can use it for my mod :) i'am going credit. anyways just if they change language of the game why they need to restart you must implement something but its good

It has maybe another way to get the language in real time but I haven't found out.

@gabrielyotoo
Copy link

Hey, everyone!
Is there any plans to keep working on this? I think it would be great for non-english speakers who want to play the mod :)

I can help updating this PR or even creating a new one if needed.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants