feat: allow anonymous github emails#4
Open
shpingalet007 wants to merge 6 commits intoeErbLiddle:mainfrom
Open
Conversation
* Add build scripts * Install @vercel/ncc * Update package-lock.json
shpingalet007
force-pushed
the
feat/allow-anon-flag
branch
from
b0662ae to
2521bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Thank you, @evvanErb for your repository. I work with CI/CD in our team project, and your action does a good job.
A few months ago, I switched to an anonymous GitHub email address. However, it was after that I tried your repository. And when I went back a few days ago, I found that it wasn't working for me. After some investigation, I saw that you limited the action to not include anonymous GitHub email addresses. I assume the module was created for other use cases, but I would like to promote this PR.
I need my anonymous email address to be able to push automatically a commit that is authored by me. So it doesn't matter to me if it's a real address or not.
Changes
allow-anonymous, set to false by defaultOther changes
build:cleanandbuild@vercel/nccforbuildscriptbuildscript produces a minified result. It reduced the size of the bundle by 30%.dist/xhr-sync-worker.js