Skip to content

Send Bonus Milestone self-report and use API season rules - #55

Open
hoangsvit wants to merge 15 commits into
mainfrom
fix/arcade-bonus-milestone-api-sync
Open

Send Bonus Milestone self-report and use API season rules#55
hoangsvit wants to merge 15 commits into
mainfrom
fix/arcade-bonus-milestone-api-sync

Conversation

@hoangsvit

@hoangsvit hoangsvit commented Aug 18, 2026

Copy link
Copy Markdown
Member

Changes

  • Web and Widget keep the normal Arcade request payload and add only facilitator.bonusMilestoneCompleted; no Facilitator participation flag is sent.
  • The self-report comes from the existing per-profile manual Bonus Milestone completion state. Shared profiles use only their explicit bonus=1 flag.
  • Standard Facilitator milestone scoring stays unchanged.
  • Bonus Milestone value and availability come from API metadata. Current API responses can change the points or disable the Bonus without a Web/Widget scoring-rule release.
  • Use bonusMilestonePoints when the API response matches the current self-report state; use bonusMilestoneAvailablePoints for the immediate optimistic toggle before the refreshed response arrives.
  • Keep +10 only as a compatibility fallback for legacy API responses that do not expose Bonus Milestone metadata.

API dependency

Consumes the season-owned Bonus Milestone contract from hoangsvit/hub.eplus.dev#174.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🚀 PR preview ready

Open the live preview

  • Commit: 43643fe
  • Pages artifact deployed successfully
  • Live URL verified successfully
  • Google Analytics remains disabled in previews
  • Updates automatically when new commits are pushed

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d2bf3672-7f33-45db-9a0a-44ba3a0bca67


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
@hoangsvit hoangsvit changed the title Sync web and widget Bonus Milestone scoring with API Sync manual Bonus Milestone value with API metadata Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
@hoangsvit hoangsvit changed the title Sync manual Bonus Milestone value with API metadata Send Bonus Milestone self-report and use API season rules Aug 18, 2026
github-actions Bot added a commit that referenced this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant