Skip to content

Fix action notification callback #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanlofer-eprosima merged 2 commits into from
Nov 25, 2025
Merged

Fix action notification callback #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c657ee
Fix action notification callback
juanlofer-eprosima Nov 25, 2025
d322cb1
Add feedback comment on action example
juanlofer-eprosima Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddsenabler/examples/action/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ bool server_specific_logic(
{
std::vector<uint64_t> fibonacci_sequence = {0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610};
std::string json = "{\"sequence\": [";
std::string feedback_json = "{\"partial_sequence\": [";
std::string feedback_json = "{\"partial_sequence\": ["; // From Kilted onwardards, the feedback attribute name is "sequence"
for (size_t i = 0; i < fibonacci_number; ++i)
{
{
Expand Down
8 changes: 4 additions & 4 deletions ddsenabler_participants/src/cpp/Writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,14 @@ void Writer::write_action_notification(
TopicInfo(action.goal.request_topic().type_name, goal_request_serialized_qos),
TopicInfo(action.goal.reply_topic().type_name, goal_reply_serialized_qos)
),
ServiceInfo(
TopicInfo(action.cancel.request_topic().type_name, cancel_request_serialized_qos),
TopicInfo(action.cancel.reply_topic().type_name, cancel_reply_serialized_qos)
),
ServiceInfo(
TopicInfo(action.result.request_topic().type_name, result_request_serialized_qos),
TopicInfo(action.result.reply_topic().type_name, result_reply_serialized_qos)
),
ServiceInfo(
TopicInfo(action.cancel.request_topic().type_name, cancel_request_serialized_qos),
TopicInfo(action.cancel.reply_topic().type_name, cancel_reply_serialized_qos)
),
TopicInfo(action.feedback.type_name, feedback_serialized_qos),
TopicInfo(action.status.type_name, status_serialized_qos)
));
Expand Down