[#24607] Fix macOS/Clang debug warnings#32
Merged
Conversation
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
ZakariaTalbi
self-requested a review
June 12, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a macOS/Clang warning in ddsenabler_participants by deleting the default constructor of RpcAction.
Problem
RpcAction declared:
RpcAction() = default;
but the type contains several ddspipe::core::types::RpcTopic members, and RpcTopic is not default-constructible.
On Clang, this triggers:
-Wdefaulted-function-deleted
warning that the explicitly defaulted constructor is implicitly deleted