[21768] DDS data publication implementation#5
Merged
Conversation
EugenioCollado
force-pushed
the
feature/publish-data
branch
from
January 29, 2025 15:18
85fb5a5 to
d49c49f
Compare
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
May 9, 2025 10:21
36a4f7d to
9d0ffc0
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
May 12, 2025 09:09
56539f6 to
422ab7a
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
May 28, 2025 10:37
fe33bc9 to
18db200
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
EugenioCollado
self-requested a review
June 2, 2025 14:41
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
4 times, most recently
from
June 4, 2025 11:53
ae71ddf to
b7b9464
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
June 4, 2025 12:56
b7b9464 to
f465d47
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
2 times, most recently
from
June 5, 2025 05:48
29d5812 to
915cb76
Compare
There was a problem hiding this comment.
Pull Request Overview
Implements DDS data publication by extending the enabler API, refactoring callbacks into a CallbackSet, and updating tests and examples to cover topic notifications and sample publishing.
- Introduce
CallbackSetand updatecreate_dds_enablersignatures to accept it - Add
DDSEnabler::publishmethod and wire up publication in runner and examples - Update tests to assert on received topics and comment out a large block of optional typed tests
Reviewed Changes
Copilot reviewed 91 out of 91 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt (typed tests) | Comment out many optional ddsenabler_send_samples_* entries |
| ReloadConfig.cpp | Refactor callbacks into CallbackSet, fix formatting |
| DdsEnablerTest.cpp | Add get_received_topics() assertions alongside types/data |
| DDSEnablerTester.hpp | Introduce received_topics_, get_received_topics() |
| dds_enabler_runner.cpp | Overload create_dds_enabler, drop old callbacks API |
| DDSEnabler.cpp / DDSEnabler.hpp | Inject CallbackSet, add publish and set_internal_callbacks_ |
| CallbackSet.hpp | New struct defining DDS and log callbacks |
| project_settings.cmake | Bump to C++20 |
| examples and CLIParser | Wire up persistence, file I/O helpers, CLI options |
| GitHub workflows | Enable examples, repeat-until-fail on CI tests |
Comments suppressed due to low confidence (4)
ddsenabler/test/ddsEnablerTests/ReloadConfig.cpp:161
- In
write_yaml_filethere is nobufferdeclared, leading to an undefined identifier. You need to declare and populate abuffer(similar towrite_json_file) or writeTemplatedirectly.
outFile << buffer;
ddsenabler/test/ddsEnablerTests/ReloadConfig.cpp:139
- [nitpick] The variable name
Templateconflicts with the C++ keyword and general naming conventions. Consider renaming it toyamlTemplateor similar.
std::string Template =
ddsenabler/include/ddsenabler/DDSEnabler.hpp:102
- The new
publish()API is not covered by any unit tests—consider adding tests to validate JSON publishing and error paths.
bool publish(
ddsenabler/test/ddsEnablerTests/ReloadConfig.cpp:122
- [nitpick] Brace placement style changed here (opening brace on new line) but other sites in this file use the same-line style. Align with the project's coding style for consistency.
if (outFile.is_open())
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
June 6, 2025 10:23
915cb76 to
79d9c19
Compare
EugenioCollado
requested changes
Jun 10, 2025
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
June 12, 2025 09:11
d7f8802 to
aabc30a
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
June 12, 2025 10:34
aabc30a to
71da6f2
Compare
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
feature/publish-data
branch
from
June 17, 2025 06:01
6c152e0 to
b2ced8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after: