Skip to content

Support repeater feature in DDS (XML) participants#151

Merged
rsanchez15 merged 3 commits into
mainfrom
feature/dds-repeater
Jul 17, 2025
Merged

Support repeater feature in DDS (XML) participants#151
rsanchez15 merged 3 commits into
mainfrom
feature/dds-repeater

Conversation

@juanlofer-eprosima

@juanlofer-eprosima juanlofer-eprosima commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

This PR adds the possibility to configure DDS (XML) participants so they support the repeater feature, which up to now has been available only for RTPS participants. The implementation relies on the new feature introduced in eProsima/Fast-DDS#5861.

@codecov-commenter

codecov-commenter commented Jul 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 21.42857% with 33 lines in your changes missing coverage. Please review.

Project coverage is 37.86%. Comparing base (5b319e9) to head (09e37be).

Files with missing lines Patch % Lines
...e_participants/src/cpp/writer/dds/CommonWriter.cpp 14.28% 16 Missing and 2 partials ⚠️
...s/src/cpp/writer/dds/filter/RepeaterDataFilter.cpp 0.00% 8 Missing ⚠️
...pants/src/cpp/writer/dds/filter/SelfDataFilter.cpp 0.00% 2 Missing ⚠️
ddspipe_yaml/src/cpp/YamlReader_participants.cpp 0.00% 2 Missing ⚠️
...ants/src/cpp/participant/dds/CommonParticipant.cpp 66.66% 0 Missing and 1 partial ⚠️
...pe_participants/src/cpp/writer/dds/MultiWriter.cpp 66.66% 1 Missing ⚠️
...ticipants/src/cpp/writer/dds/QoSSpecificWriter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   37.98%   37.86%   -0.13%     
==========================================
  Files         153      155       +2     
  Lines        7018     7047      +29     
  Branches     2786     2796      +10     
==========================================
+ Hits         2666     2668       +2     
- Misses       2952     2977      +25     
- Partials     1400     1402       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread ddspipe_participants/src/cpp/writer/dds/filter/SelfDataFilter.cpp
rsanchez15
rsanchez15 previously approved these changes Jul 16, 2025
@rsanchez15
rsanchez15 self-requested a review July 16, 2025 05:36
@rsanchez15
rsanchez15 dismissed their stale review July 16, 2025 05:36

Missing requested changes

@rsanchez15 rsanchez15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@rsanchez15
rsanchez15 merged commit 2d4e84c into main Jul 17, 2025
15 checks passed
@rsanchez15
rsanchez15 deleted the feature/dds-repeater branch July 17, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants