Skip to content

Further isolate attributes/QoS and properties configuration#156

Merged
emiliocuestaf merged 1 commit into
mainfrom
feature/properties-attributes-separation
Jul 17, 2025
Merged

Further isolate attributes/QoS and properties configuration#156
emiliocuestaf merged 1 commit into
mainfrom
feature/properties-attributes-separation

Conversation

@juanlofer-eprosima

@juanlofer-eprosima juanlofer-eprosima commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Isolate the configuration of attributes/QoS and their properties. This would mainly improve the design pattern and increase flexibility, but also prevent cases such as setting the same properties twice in an XML participant whose profile is not defined. Also, the following minor changes have been introduced:

  • export missing virtual protected (related) methods
  • set name in DDS participants

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.98%. Comparing base (85b1ef2) to head (5bd8123).

Files with missing lines Patch % Lines
...ants/src/cpp/participant/dds/CommonParticipant.cpp 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   37.95%   37.98%   +0.03%     
==========================================
  Files         153      153              
  Lines        7017     7018       +1     
  Branches     2788     2786       -2     
==========================================
+ Hits         2663     2666       +3     
  Misses       2952     2952              
+ Partials     1402     1400       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emiliocuestaf emiliocuestaf self-assigned this Jul 17, 2025

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emiliocuestaf
emiliocuestaf merged commit 5b319e9 into main Jul 17, 2025
15 checks passed
@emiliocuestaf
emiliocuestaf deleted the feature/properties-attributes-separation branch July 17, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants