Skip to content

[#24061] Update DDS-Pipe filters#174

Merged
Danipiza merged 23 commits into
mainfrom
feature/new-filter
Feb 17, 2026
Merged

[#24061] Update DDS-Pipe filters#174
Danipiza merged 23 commits into
mainfrom
feature/new-filter

Conversation

@Danipiza

@Danipiza Danipiza commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Description

Updated DDS-Pipe for filter feature in Fast-DDS-Spy and DDS-Record-Replay.

Deleted previous implementation of the filter, before it removed and created datareaders when the filter of partitions was updated. Now, when a filter (partition or topic) is updated, the datareaders are updated, by refreshing the partitions qos or ContentFilteredTopic expression of the readers.

Related PR: [#23686] Support "partitions" in DDS-spy

🟢 Fast-DDS-Spy Action

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@codecov-commenter

codecov-commenter commented Jan 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 264 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.40%. Comparing base (834719c) to head (2f8a637).

Files with missing lines Patch % Lines
ddspipe_core/src/cpp/core/DdsPipe.cpp 28.33% 39 Missing and 4 partials ⚠️
...e_participants/src/cpp/reader/dds/CommonReader.cpp 9.09% 23 Missing and 7 partials ⚠️
ddspipe_yaml/src/cpp/YamlReader_types.cpp 11.76% 12 Missing and 18 partials ⚠️
...ants/src/cpp/participant/dds/CommonParticipant.cpp 27.02% 9 Missing and 18 partials ⚠️
...e_participants/src/cpp/writer/dds/CommonWriter.cpp 4.34% 19 Missing and 3 partials ⚠️
..._participants/src/cpp/reader/rtps/CommonReader.cpp 13.63% 16 Missing and 3 partials ⚠️
..._participants/src/cpp/writer/rtps/CommonWriter.cpp 12.50% 13 Missing and 1 partial ⚠️
ddspipe_core/src/cpp/communication/dds/Track.cpp 0.00% 11 Missing ⚠️
...spipe_core/src/cpp/communication/dds/DdsBridge.cpp 0.00% 10 Missing ⚠️
...nts/src/cpp/participant/rtps/CommonParticipant.cpp 10.00% 5 Missing and 4 partials ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   35.90%   36.40%   +0.50%     
==========================================
  Files         174      157      -17     
  Lines       12323     7486    -4837     
  Branches     5632     2979    -2653     
==========================================
- Hits         4424     2725    -1699     
+ Misses       5076     3312    -1764     
+ Partials     2823     1449    -1374     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated
Comment thread ddspipe_core/include/ddspipe_core/communication/dds/Track.hpp
Comment thread ddspipe_core/include/ddspipe_core/core/DdsPipe.hpp
Comment thread ddspipe_core/include/ddspipe_core/communication/dds/DdsBridge.hpp Outdated
Comment thread ddspipe_participants/src/cpp/testing/entities/mock_entities.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/auxiliar/InternalWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/auxiliar/RtpsEchoWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/dds/CommonWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/dds/MultiWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/dynamic_types/SchemaWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/dynamic_types/TypeObjectWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/rtps/CommonWriter.cpp Outdated
Comment thread ddspipe_participants/src/cpp/writer/rtps/MultiWriter.cpp Outdated
…ing them

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
…tion + 'is_fastddsspy' bool

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza and others added 7 commits February 16, 2026 07:55
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review

Comment thread ddspipe_participants/include/ddspipe_participants/reader/dds/CommonReader.hpp Outdated
Comment thread ddspipe_participants/src/cpp/reader/dds/CommonReader.cpp Outdated
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp Outdated
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp
Comment thread ddspipe_participants/src/cpp/writer/dds/CommonWriter.cpp
Comment thread ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp
Comment thread ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp
Comment thread ddspipe_participants/src/cpp/writer/dds/CommonWriter.cpp Outdated
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza merged commit 0032cdd into main Feb 17, 2026
15 checks passed
@Danipiza
Danipiza deleted the feature/new-filter branch February 17, 2026 10:54
@Danipiza
Danipiza restored the feature/new-filter branch February 20, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants