Skip to content

[#24061] Add const reference in 'update_partitions()' #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danipiza merged 1 commit into from
Mar 3, 2026
Merged

[#24061] Add const reference in 'update_partitions()' #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddspipe_core/include/ddspipe_core/interface/IParticipant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class IParticipant
*/
DDSPIPE_CORE_DllAPI
virtual void update_partitions(
std::set<std::string> partitions) = 0;
const std::set<std::string>& partitions) = 0;

/**
* Update the content_topicfilter data structure of the participant
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/include/ddspipe_participants/participant/auxiliar/BlankParticipant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class BlankParticipant : public core::IParticipant
//! Override update_partitions() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
virtual void update_partitions(
std::set<std::string> partitions) override;
const std::set<std::string>& partitions) override;

//! Override update_content_topicfilter() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/include/ddspipe_participants/participant/dds/CommonParticipant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class CommonParticipant : public core::IParticipant
//! Override update_partitions() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
virtual void update_partitions(
std::set<std::string> partitions) override;
const std::set<std::string>& partitions) override;

//! Override update_content_topicfilter() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
Expand Down
2 changes: 1 addition & 1 deletion ...participants/include/ddspipe_participants/participant/dynamic_types/SchemaParticipant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class SchemaParticipant : public core::IParticipant
//! Override update_partitions() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
virtual void update_partitions(
std::set<std::string> partitions) override;
const std::set<std::string>& partitions) override;

//! Override update_content_topicfilter() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/include/ddspipe_participants/participant/rtps/CommonParticipant.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class CommonParticipant
//! Override update_partitions() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
virtual void update_partitions(
std::set<std::string> partitions) override;
const std::set<std::string>& partitions) override;

//! Override update_content_topicfilter() IParticipant method
DDSPIPE_PARTICIPANTS_DllAPI
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/src/cpp/participant/auxiliar/BlankParticipant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ void BlankParticipant::clear_topic_partitions()
}

void BlankParticipant::update_partitions(
std::set<std::string> partitions)
const std::set<std::string>& partitions)
{
// Nothing
}
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ fastdds::dds::Topic* CommonParticipant::topic_related_(
}

void CommonParticipant::update_partitions(
std::set<std::string> partitions)
const std::set<std::string>& partitions)
{
partition_filter_set_ = std::move(partitions);
}
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/src/cpp/participant/dynamic_types/SchemaParticipant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void SchemaParticipant::clear_topic_partitions()
}

void SchemaParticipant::update_partitions(
std::set<std::string> partitions)
const std::set<std::string>& partitions)
{
// Nothing
}
Expand Down
2 changes: 1 addition & 1 deletion ddspipe_participants/src/cpp/participant/rtps/CommonParticipant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ void CommonParticipant::clear_topic_partitions()
}

void CommonParticipant::update_partitions(
std::set<std::string> partitions)
const std::set<std::string>& partitions)
{
partition_filter_set_ = std::move(partitions);
}
Expand Down