[#24333] Removed TopicDataType unnecessary code#180
Merged
Conversation
…inistic instance-handle generation for mcap and sql Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 35.98% 36.46% +0.48%
==========================================
Files 174 157 -17
Lines 12364 7527 -4837
Branches 5662 2988 -2674
==========================================
- Hits 4449 2745 -1704
+ Misses 5047 3328 -1719
+ Partials 2868 1454 -1414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raulojeda22
requested changes
Apr 9, 2026
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverted
TopicDataType.cppchanges from #177Solved this error in the ReplayerParticipants of DDS-Recorder-Replay
DDS-Recorder-Replay related PR [#24302] Fix replay behavior to avoid runtime aborts and keyed-topic issues