Skip to content

[#24333] Removed TopicDataType unnecessary code#180

Merged
Danipiza merged 3 commits into
mainfrom
hotfix/ddsreplayer
Apr 9, 2026
Merged

[#24333] Removed TopicDataType unnecessary code#180
Danipiza merged 3 commits into
mainfrom
hotfix/ddsreplayer

Conversation

@Danipiza

@Danipiza Danipiza commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description

Reverted TopicDataType.cpp changes from #177

Solved this error in the ReplayerParticipants of DDS-Recorder-Replay

2026-03-03 11:55:47.340 [DATA_WRITER Error] Could not compute key for data -> Function create_new_change_with_params

DDS-Recorder-Replay related PR [#24302] Fix replay behavior to avoid runtime aborts and keyed-topic issues

…inistic instance-handle generation for mcap and sql

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@codecov-commenter

codecov-commenter commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.46%. Comparing base (29eb074) to head (fc84e26).

Files with missing lines Patch % Lines
...e_participants/src/cpp/types/dds/TopicDataType.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   35.98%   36.46%   +0.48%     
==========================================
  Files         174      157      -17     
  Lines       12364     7527    -4837     
  Branches     5662     2988    -2674     
==========================================
- Hits         4449     2745    -1704     
+ Misses       5047     3328    -1719     
+ Partials     2868     1454    -1414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Comment thread ddspipe_participants/src/cpp/types/dds/TopicDataType.cpp Outdated
Signed-off-by: danipiza <dpizarrogallego@gmail.com>

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza merged commit 0357610 into main Apr 9, 2026
16 checks passed
@Danipiza
Danipiza deleted the hotfix/ddsreplayer branch April 9, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants