[24566] Improve checks for sequence lengths (backport #327)#328
Merged
Conversation
* Refs #24566. Improve tests. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #24566. Check sequence length in XCDR2 path. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #24566. Check dheader and improve error state. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #24566. Remove unused variables. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #24566. Uncrustify. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit db7e730)
MiguelCompany
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the
check_bad_length_deserializationtests to include a DHEADER when required, adds a missing check on sequence length, and adds checks when deserializing a DHEADER.@Mergifyio backport 2.3.x 2.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
This is an automatic backport of pull request #327 done by [Mergify](https://mergify.com).