Skip to content

[24566] Improve checks for sequence lengths (backport #327)#328

Merged
MiguelCompany merged 1 commit into
2.3.xfrom
mergify/bp/2.3.x/pr-327
Jul 2, 2026
Merged

[24566] Improve checks for sequence lengths (backport #327)#328
MiguelCompany merged 1 commit into
2.3.xfrom
mergify/bp/2.3.x/pr-327

Conversation

@mergify

@mergify mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Description

This improves the check_bad_length_deserialization tests to include a DHEADER when required, adds a missing check on sequence length, and adds checks when deserializing a DHEADER.

@Mergifyio backport 2.3.x 2.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

This is an automatic backport of pull request #327 done by [Mergify](https://mergify.com).

* Refs #24566. Improve tests.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #24566. Check sequence length in XCDR2 path.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #24566. Check dheader and improve error state.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #24566. Remove unused variables.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #24566. Uncrustify.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit db7e730)
@mergify mergify Bot mentioned this pull request Jul 2, 2026
12 tasks
@MiguelCompany MiguelCompany added this to the v2.3.7 milestone Jul 2, 2026
@MiguelCompany
MiguelCompany self-requested a review July 2, 2026 09:22
@MiguelCompany
MiguelCompany merged commit abfc5dd into 2.3.x Jul 2, 2026
13 checks passed
@MiguelCompany
MiguelCompany deleted the mergify/bp/2.3.x/pr-327 branch July 2, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant