-
Notifications
You must be signed in to change notification settings - Fork 64
[21921] Sign the generated code with the Fast DDS-Gen version #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Denisa <[email protected]>
d639e27
to
3bc56c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/com/eprosima/fastdds/idl/grammar/Context.java:484
- Consider checking whether 'input' is null before calling methods like available() to prevent a potential NullPointerException when the resource is missing.
InputStream input = this.getClass().getClassLoader().getResourceAsStream("version");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@Mergifyio backport 4.0.x 3.3.x 2.5.x 2.1.x |
✅ Backports have been created
|
Signed-off-by: Denisa <[email protected]> (cherry picked from commit a2ff4a4)
Signed-off-by: Denisa <[email protected]> (cherry picked from commit a2ff4a4)
Signed-off-by: Denisa <[email protected]> (cherry picked from commit a2ff4a4) # Conflicts: # src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg
Signed-off-by: Denisa <[email protected]> (cherry picked from commit a2ff4a4) # Conflicts: # src/main/java/com/eprosima/fastdds/idl/grammar/Context.java # src/main/java/com/eprosima/fastdds/idl/templates/eprosima.stg
Description
This PR adds the Version of Fast DDS-Gen to the generated code.
@Mergifyio backport 4.0.x 3.3.x 2.5.x 2.1.x
Contributor Checklist
Reviewer Checklist