Skip to content

Commit 26de35f

Browse files
committed
Refs #23264: Fix compilation warnings
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
1 parent ccbbfcb commit 26de35f

4 files changed

Lines changed: 14 additions & 2 deletions

File tree

include/fastdds/dds/topic/IContentFilter.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ namespace dds {
3535
*/
3636
struct IContentFilter
3737
{
38+
virtual ~IContentFilter() = default;
39+
3840
using SerializedPayload = eprosima::fastdds::rtps::SerializedPayload_t;
3941
using GUID_t = fastdds::rtps::GUID_t;
4042

include/fastdds/rtps/common/WriteParams.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,13 @@ class FASTDDS_EXPORTED_API WriteParams
4444
* classes to be deleted safely through a pointer to this base type.
4545
* It is intended to be user-extensible.
4646
*/
47-
struct UserWriteData
47+
struct FASTDDS_EXPORTED_API UserWriteData
4848
{
4949
virtual ~UserWriteData() = default;
5050
};
5151

52+
using UserWriteDataPtr = FASTDDS_EXPORTED_API std::shared_ptr<UserWriteData>;
53+
5254
/**
5355
* Set the value of the sample_identity member.
5456
*
@@ -244,7 +246,7 @@ class FASTDDS_EXPORTED_API WriteParams
244246
/// Attribute that holds source_timestamp member value
245247
Time_t source_timestamp_{ -1, TIME_T_INFINITE_NANOSECONDS };
246248
/// User write data
247-
std::shared_ptr<UserWriteData> user_write_data_ = nullptr;
249+
UserWriteDataPtr user_write_data_ = nullptr;
248250
};
249251

250252
} // namespace rtps

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -740,6 +740,8 @@ TEST_P(DDSContentFilter, filter_with_prefilter)
740740

741741
struct CustomPreFilter : public eprosima::fastdds::dds::IContentFilter
742742
{
743+
virtual ~CustomPreFilter();
744+
743745
//! Custom filter for the HelloWorld example
744746
bool evaluate(
745747
const SerializedPayload& payload,

test/blackbox/common/DDSBlackboxTestsDataWriter.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,6 +1307,8 @@ TEST(DDSDataWriter, datawriter_prefilter_precondition_not_met)
13071307
{
13081308
struct CustomPreFilter : public eprosima::fastdds::dds::IContentFilter
13091309
{
1310+
virtual ~CustomPreFilter();
1311+
13101312
//! Custom filter for the HelloWorld example
13111313
bool evaluate(
13121314
const SerializedPayload&,
@@ -1356,6 +1358,8 @@ TEST_P(DDSDataWriter, datawriter_prefilter_filtering_by_write_params)
13561358

13571359
struct CustomPreFilter : public eprosima::fastdds::dds::IContentFilter
13581360
{
1361+
virtual ~CustomPreFilter();
1362+
13591363
//! Custom filter for the HelloWorld example
13601364
bool evaluate(
13611365
const SerializedPayload&,
@@ -1450,6 +1454,8 @@ TEST_P(DDSDataWriter, datawriter_prefilter_filtering_by_payload)
14501454

14511455
struct CustomPreFilter : public eprosima::fastdds::dds::IContentFilter
14521456
{
1457+
virtual ~CustomPreFilter();
1458+
14531459
//! Custom filter for the HelloWorld example
14541460
bool evaluate(
14551461
const SerializedPayload& payload,

0 commit comments

Comments
 (0)