[22469] Avoid calling setIPv4 in TCPTransportInterface by cferreiragonz · Pull Request #5492 · eProsima/Fast-DDS

cferreiragonz · 2024-12-13T11:04:49Z

Description

This PR adds a new method copyAddress which allows to copy the whole address of one locator to another. It uses this method to replace the setIPv4 method of TCPTransportInterace introduced in #5382 which caused undesired warnings.

It also excludes TCPv6 cases from this logic, leaving TCPv6 comms as before #5382.

@Mergifyio backport 3.1.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL

LGTM with green CI

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Mario-DL

Couple of NITs

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Mario-DL

LGTM with green CI

MiguelCompany · 2025-06-19T14:59:51Z

@Mergifyio backport 3.2.x 2.14.x

mergify · 2025-06-19T15:00:19Z

backport 3.2.x 2.14.x

✅ Backports have been created

Details

#5892 [22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492) has been created for branch 3.2.x
#5893 [22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492) has been created for branch 2.14.x but encountered conflicts

* Refs #22469: Regression Tests for IPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: New method copyAddress Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Fix TCPTransportInterface Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Disable grouping of locators in single channel for TCPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Allow to copyIPv4 between two locators Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review 2 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit f2a55e9) # Conflicts: # include/fastrtps/utils/IPLocator.h # src/cpp/rtps/transport/TCPTransportInterface.cpp

* Refs #22469: Regression Tests for IPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: New method copyAddress Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Fix TCPTransportInterface Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Disable grouping of locators in single channel for TCPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Allow to copyIPv4 between two locators Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review 2 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit f2a55e9)

* Refs #22469: Regression Tests for IPv6 * Refs #22469: New method copyAddress * Refs #22469: Fix TCPTransportInterface * Refs #22469: Apply Review * Refs #22469: Disable grouping of locators in single channel for TCPv6 * Refs #22469: Uncrustify * Refs #22469: Apply review * Refs #22469: Allow to copyIPv4 between two locators * Refs #22469: Apply Review 2 --------- (cherry picked from commit f2a55e9) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #22469: Regression Tests for IPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: New method copyAddress Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Fix TCPTransportInterface Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Disable grouping of locators in single channel for TCPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply review Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Allow to copyIPv4 between two locators Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22469: Apply Review 2 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Refs #22469: Regression Tests for IPv6 * Refs #22469: New method copyAddress * Refs #22469: Fix TCPTransportInterface * Refs #22469: Apply Review * Refs #22469: Disable grouping of locators in single channel for TCPv6 * Refs #22469: Uncrustify * Refs #22469: Apply review * Refs #22469: Allow to copyIPv4 between two locators * Refs #22469: Apply Review 2 --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz added needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Dec 13, 2024

cferreiragonz added this to the v3.2.0 milestone Dec 13, 2024

cferreiragonz requested review from richiprosima and removed request for richiprosima December 13, 2024 11:05

MiguelCompany self-requested a review December 13, 2024 12:10

MiguelCompany requested changes Dec 13, 2024

View reviewed changes

Comment thread include/fastdds/utils/IPLocator.hpp Outdated

Comment thread test/unittest/utils/LocatorTests.cpp

cferreiragonz requested a review from MiguelCompany December 13, 2024 13:03

cferreiragonz added the temporarily-blocked PR must be merged after another one label Feb 4, 2025

MiguelCompany modified the milestones: v3.2.0, v3.3.0 Mar 17, 2025

cferreiragonz force-pushed the bugfix/copyAddress_in_TCPTransport branch from 62a024b to efa36b3 Compare June 17, 2025 14:18

cferreiragonz requested review from richiprosima and removed request for richiprosima June 17, 2025 14:18

cferreiragonz force-pushed the bugfix/copyAddress_in_TCPTransport branch from efa36b3 to 9fa0768 Compare June 17, 2025 14:38

cferreiragonz requested review from richiprosima and removed request for richiprosima June 17, 2025 14:39

Mario-DL suggested changes Jun 18, 2025

View reviewed changes

Comment thread src/cpp/utils/IPLocator.cpp Outdated

Comment thread src/cpp/utils/IPLocator.cpp Outdated

Comment thread src/cpp/rtps/transport/TCPTransportInterface.cpp Outdated

cferreiragonz requested review from richiprosima and removed request for richiprosima June 18, 2025 13:19

Mario-DL previously approved these changes Jun 18, 2025

View reviewed changes

cferreiragonz dismissed Mario-DL’s stale review via e8d8e7f June 19, 2025 06:38

cferreiragonz requested review from richiprosima and removed request for richiprosima June 19, 2025 06:38

cferreiragonz force-pushed the bugfix/copyAddress_in_TCPTransport branch from e8d8e7f to 50fea53 Compare June 19, 2025 06:45

cferreiragonz requested review from richiprosima and removed request for richiprosima June 19, 2025 06:45

cferreiragonz removed the temporarily-blocked PR must be merged after another one label Jun 19, 2025

cferreiragonz added 2 commits June 19, 2025 09:04

Refs #22469: Regression Tests for IPv6

23644be

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: New method copyAddress

6f812ce

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz added 6 commits June 19, 2025 09:04

Refs #22469: Fix TCPTransportInterface

e2b5910

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: Apply Review

0574146

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: Disable grouping of locators in single channel for TCPv6

4d87589

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: Uncrustify

661b0be

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: Apply review

086b8e1

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #22469: Allow to copyIPv4 between two locators

d4ce08c

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz force-pushed the bugfix/copyAddress_in_TCPTransport branch from 50fea53 to d4ce08c Compare June 19, 2025 07:04

cferreiragonz requested review from richiprosima and removed request for richiprosima June 19, 2025 07:05

Mario-DL suggested changes Jun 19, 2025

View reviewed changes

Comment thread src/cpp/utils/IPLocator.cpp Outdated

Comment thread include/fastdds/utils/IPLocator.hpp Outdated

Refs #22469: Apply Review 2

8876ccb

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Mario-DL approved these changes Jun 19, 2025

View reviewed changes

Mario-DL requested review from Mario-DL and removed request for Mario-DL and MiguelCompany June 19, 2025 07:28

MiguelCompany approved these changes Jun 19, 2025

View reviewed changes

MiguelCompany merged commit f2a55e9 into master Jun 19, 2025
22 checks passed

MiguelCompany deleted the bugfix/copyAddress_in_TCPTransport branch June 19, 2025 14:57

This was referenced Jun 19, 2025

[22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492) #5892

Merged

[22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492) #5893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[22469] Avoid calling setIPv4 in TCPTransportInterface#5492

[22469] Avoid calling setIPv4 in TCPTransportInterface#5492
MiguelCompany merged 9 commits into
masterfrom
bugfix/copyAddress_in_TCPTransport

cferreiragonz commented Dec 13, 2024 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mario-DL left a comment

Uh oh!

Mario-DL left a comment

Uh oh!

Uh oh!

Uh oh!

Mario-DL left a comment

Uh oh!

Uh oh!

MiguelCompany commented Jun 19, 2025

Uh oh!

mergify Bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

cferreiragonz commented Dec 13, 2024 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mario-DL left a comment

Choose a reason for hiding this comment

Uh oh!

Mario-DL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Mario-DL left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MiguelCompany commented Jun 19, 2025

Uh oh!

mergify Bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cferreiragonz commented Dec 13, 2024 •

edited by MiguelCompany

Loading

mergify Bot commented Jun 19, 2025 •

edited

Loading