-
Notifications
You must be signed in to change notification settings - Fork 885
[22931] Fix assertion on OutputTrafficManager (backport #5704)
#5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp # src/cpp/rtps/writer/StatelessWriter.cpp
Contributor
Author
|
Cherry-pick of 777a71b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
13 tasks
Member
|
@Mergifyio backport 2.14.x 2.10.x |
Contributor
Author
✅ Backports have been createdDetails
|
MiguelCompany
approved these changes
Mar 18, 2025
mergify bot
added a commit
that referenced
this pull request
Mar 18, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp # src/cpp/rtps/writer/StatelessWriter.cpp * Fix conflicts --------- Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 2c7e56f) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.h # src/cpp/statistics/rtps/messages/OutputTrafficManager.hpp
13 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 18, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) # Conflicts: # src/cpp/rtps/reader/StatelessReader.cpp # src/cpp/rtps/writer/StatelessWriter.cpp * Fix conflicts --------- Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 2c7e56f) # Conflicts: # src/cpp/rtps/participant/RTPSParticipantImpl.cpp # src/cpp/rtps/participant/RTPSParticipantImpl.h # src/cpp/rtps/writer/StatelessWriter.cpp # src/cpp/statistics/rtps/messages/OutputTrafficManager.hpp
13 tasks
MiguelCompany
added a commit
that referenced
this pull request
May 29, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) * Fix conflicts --------- Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
May 29, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) * Fix conflicts --------- Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
May 30, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit 777a71b) * Fix conflicts --------- Co-authored-by: Miguel Company <[email protected]>
MiguelCompany
added a commit
that referenced
this pull request
May 30, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. * Refs #22930. Create sender resources on stateless readers. * Refs #22930. Similar changes on writers. * Refs #22930: Test TCP with best effort reader * Refs #22930: Uncrustify --------- (cherry picked from commit 777a71b) * Fix conflicts --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Miguel Company <[email protected]>
EugenioCollado
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Eugenio Collado <[email protected]>
EugenioCollado
pushed a commit
that referenced
this pull request
Jun 30, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Create sender resources on stateless readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930. Similar changes on writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22930: Test TCP with best effort reader Signed-off-by: cferreiragonz <[email protected]> * Refs #22930: Uncrustify Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Eugenio Collado <[email protected]> Uncrustify Signed-off-by: Eugenio Collado <[email protected]>
EugenioCollado
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Fix assertion on `OutputTrafficManager` (#5704) * Refs #22930. Add entry when missing on `set_statistics_message_data`. * Refs #22930. Create sender resources on stateless readers. * Refs #22930. Similar changes on writers. * Refs #22930: Test TCP with best effort reader * Refs #22930: Uncrustify Uncrustify Signed-off-by: Eugenio Collado <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that
OpenOutputChannelis called in the transports for every locator that might be used by any reader or writer.@Mergifyio backport 3.1.x 2.14.x 2.10.x
@Mergifyio backport 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5704 done by [Mergify](https://mergify.com).