[23110] Address some compilation warnings with GCC latest #5796

Mario-DL · 2025-05-05T08:09:31Z

Description

This PR addresses issues #5790 and #5792

@Mergifyio backport 3.1.x 2.14.x 2.10.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <[email protected]>

Mario-DL · 2025-05-05T08:10:01Z

Backports to 2.x should drop the second commit regarding BaseReader

cferreiragonz · 2025-05-08T05:41:35Z

@richiprosima check style pls

Signed-off-by: cferreiragonz <[email protected]>

cferreiragonz

LGTM with green CI. I have added two extra missing includes that I found when trying to compile with gcc 15.

Mario-DL · 2025-05-08T12:37:53Z

With that headers included the compilation succeeds. I observed an extra warning warning: ‘strlen’ reading 1 or more bytes from a region of size 0 but it is presumably due to Release optimizations. We will double check that in the follow up PR introducing the CI in alternative builds

Mario-DL · 2025-05-08T13:44:34Z

CI for alternative builds with latest GCC here
(CI PR was rebased on top of this)

Mario-DL · 2025-05-09T09:57:44Z

@Mergifyio backport 3.1.x 2.14.x 2.10.x

mergify · 2025-05-09T09:57:53Z

backport 3.1.x 2.14.x 2.10.x

✅ Backports have been created

Details

#5804 [23110] Address some compilation warnings with GCC latest (backport #5796) has been created for branch 3.1.x
#5802 [23110] Address some compilation warnings with GCC latest (backport #5796) has been created for branch 2.14.x but encountered conflicts
#5803 [23110] Address some compilation warnings with GCC latest (backport #5796) has been created for branch 2.10.x but encountered conflicts

* Refs #23110: Add cstdint header for uint8_t Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Remove unused using Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Add missing cstdint to more headers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit e1524ac) # Conflicts: # src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterValue.hpp # src/cpp/rtps/reader/BaseReader.cpp

* Refs #23110: Add cstdint header for uint8_t Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Remove unused using Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Add missing cstdint to more headers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> (cherry picked from commit e1524ac)

e.g.: /meta-ros/build/tmp/work/cortexa76-oe-linux/fastdds/3.2.2-1/git/src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterValue.hpp:26:1: note: 'uint64_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>' | 25 | #include <regex> | +++ |+#include <cstdint> | 26 | See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

* Refs #23110: Add cstdint header for uint8_t Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Remove unused using Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Add missing cstdint to more headers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]>

* Refs #23110: Add cstdint header for uint8_t * Refs #23110: Remove unused using * Refs #23110: Add missing cstdint to more headers --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> Co-authored-by: cferreiragonz <[email protected]>

e.g.: /meta-ros/build/tmp/work/cortexa76-oe-linux/fastdds/3.2.2-1/git/src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterValue.hpp:26:1: note: 'uint64_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>' | 25 | #include <regex> | +++ |+#include <cstdint> | 26 | See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

* Refs #23110: Add cstdint header for uint8_t Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Remove unused using Signed-off-by: Mario Dominguez <[email protected]> * Refs #23110: Add missing cstdint to more headers Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Co-authored-by: cferreiragonz <[email protected]> Signed-off-by: Eugenio Collado <[email protected]>

* Refs #23110: Add cstdint header for uint8_t * Refs #23110: Remove unused using * Refs #23110: Add missing cstdint to more headers --------- Signed-off-by: Mario Dominguez <[email protected]> Signed-off-by: cferreiragonz <[email protected]> Signed-off-by: Eugenio Collado <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> Co-authored-by: cferreiragonz <[email protected]>

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

Mario-DL added 2 commits May 5, 2025 10:04

Refs #23110: Add cstdint header for uint8_t

c24121f

Signed-off-by: Mario Dominguez <[email protected]>

Refs #23110: Remove unused using

d7496f2

Signed-off-by: Mario Dominguez <[email protected]>

Mario-DL added this to the v3.2.3 milestone May 5, 2025

This was linked to issues May 5, 2025

Please include cstdint for gcc 15.1 #5790

Closed

[GCC15] Build error due to unused using declaration #5792

Closed

Mario-DL requested review from richiprosima and removed request for richiprosima May 5, 2025 08:19

github-actions bot added the ci-pending PR which CI is running label May 5, 2025

Refs #23110: Add missing cstdint to more headers

c9c039b

Signed-off-by: cferreiragonz <[email protected]>

cferreiragonz requested a review from richiprosima May 8, 2025 07:08

cferreiragonz approved these changes May 8, 2025

View reviewed changes

cferreiragonz removed the request for review from richiprosima May 8, 2025 07:09

Mario-DL mentioned this pull request May 8, 2025

[23139] Add compilation with GCC latest to fastdds_alternative_builds Ubuntu CI #5799

Merged

7 tasks

cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 9, 2025

Mario-DL changed the title ~~[23110] Address some compilation warnings~~ [23110] Address some compilation warnings with GCC latest May 9, 2025

MiguelCompany merged commit e1524ac into master May 9, 2025
16 of 17 checks passed

MiguelCompany deleted the bugfix/23110 branch May 9, 2025 09:55

vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 28, 2025

{rolling} fastdds: patch from upstream to fix compile issues (GCC15)

89ed185

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

vermaete added a commit to vermaete/meta-ros that referenced this pull request Jun 29, 2025

{rolling} fastdds: patch from upstream to fix compile issues (GCC15)

3a8c78d

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

vermaete added a commit to vermaete/meta-ros that referenced this pull request Jul 4, 2025

{rolling} fastdds: patch from upstream to fix compile issues (GCC15)

e7c83d3

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

vermaete added a commit to vermaete/meta-ros that referenced this pull request Jul 6, 2025

{rolling} fastdds: patch from upstream to fix compile issues (GCC15)

d737745

See: eProsima/Fast-DDS#5796 See: eProsima/Fast-DDS@e1524ac Signed-off-by: Jan Vermaete <[email protected]>

MiguelCompany mentioned this pull request Sep 17, 2025

Fix cstdint v2.12.1 #5978

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[23110] Address some compilation warnings with GCC latest #5796

[23110] Address some compilation warnings with GCC latest #5796

Uh oh!

Mario-DL commented May 5, 2025 •

edited by cferreiragonz

Loading

Uh oh!

Mario-DL commented May 5, 2025

Uh oh!

cferreiragonz commented May 8, 2025

Uh oh!

cferreiragonz left a comment

Uh oh!

Mario-DL commented May 8, 2025

Uh oh!

Mario-DL commented May 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Mario-DL commented May 9, 2025

Uh oh!

mergify bot commented May 9, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[23110] Address some compilation warnings with GCC latest #5796

[23110] Address some compilation warnings with GCC latest #5796

Uh oh!

Conversation

Mario-DL commented May 5, 2025 • edited by cferreiragonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Mario-DL commented May 5, 2025

Uh oh!

cferreiragonz commented May 8, 2025

Uh oh!

cferreiragonz left a comment

Choose a reason for hiding this comment

Uh oh!

Mario-DL commented May 8, 2025

Uh oh!

Mario-DL commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mario-DL commented May 9, 2025

Uh oh!

mergify bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mario-DL commented May 5, 2025 •

edited by cferreiragonz

Loading

Mario-DL commented May 8, 2025 •

edited

Loading

mergify bot commented May 9, 2025 •

edited

Loading