-
Notifications
You must be signed in to change notification settings - Fork 819
[23153] Improvements on RPC entities #5801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open a PR in Fast DDS Docs documenting the changes in send_request
and take_reply
methods (https://fast-dds.docs.eprosima.com/en/latest/fastdds/rpc_dds/request_reply_api/rpc_requester.html#sending-and-receiving-samples and https://fast-dds.docs.eprosima.com/en/latest/fastdds/rpc_dds/request_reply_api/rpc_replier.html#sending-and-receiving-samples), as well as the new default values in ReplierQos
and RequesterQos
.
Documented in:
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR makes requester and replier methods to return an error if they are not fully matched.
It also sets the default policies to RELIABLE, KEEP_ALL, VOLATILE.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist