Skip to content

[23169] Add WireProtocolConfigQos to optionals serialization and make Monitor Service always serialize optionals #5812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 14, 2025

Description

This PR adds the optional WireProtocolConfigQos serialization to Data(p)s based on the property fastdds.serialize_optional_qos.
It also makes monitor service to always serialize the optional qos for Data(p), Data(w) and Data(r).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.3 milestone May 14, 2025
@Mario-DL Mario-DL added needs-review PR that is ready to be reviewed doc-pending Issue or PR which is pending to be documented versions-pending labels May 14, 2025
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima May 14, 2025 08:05
@github-actions github-actions bot added the ci-pending PR which CI is running label May 14, 2025
@Mario-DL Mario-DL removed the doc-pending Issue or PR which is pending to be documented label May 14, 2025
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima May 14, 2025 13:08
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima May 14, 2025 15:29
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR adding WireProtocolConfigQos serialization! Leaving some suggestions

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from cferreiragonz and removed request for cferreiragonz May 20, 2025 07:49
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI. Will probably need to re-run asan tests. versions.md still pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running versions-pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants