-
Notifications
You must be signed in to change notification settings - Fork 818
[23169] Add WireProtocolConfigQos
to optionals serialization and make Monitor Service
always serialize optionals
#5812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
… force_write_optional_qos to write_to_cdr_message() methods Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…nly one time Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR adding WireProtocolConfigQos serialization! Leaving some suggestions
Signed-off-by: Mario Dominguez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI. Will probably need to re-run asan tests. versions.md
still pending
Description
This PR adds the optional
WireProtocolConfigQos
serialization to Data(p)s based on the propertyfastdds.serialize_optional_qos
.It also makes monitor service to always serialize the optional qos for Data(p), Data(w) and Data(r).
Contributor Checklist
versions.md
file (if applicable).WireProtocolConfigQos
Fast-DDS-docs#1068Reviewer Checklist