[23248] Fix DS initialization on "any" if no interfaces are available by cferreiragonz · Pull Request #5850 · eProsima/Fast-DDS

cferreiragonz · 2025-06-04T08:55:56Z

Description

This PR fixes a bug in which the Discovery Server initialization failed when configured to listen on any (0.0.0.0) if no interfaces were available.
It also adds a new suite of tests creating an scenario simulating that no interfaces are available, extending the test_transport functionality of simulate_no_interfaces.

This PR fixes #5835.

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
-N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

MiguelCompany · 2025-06-06T05:56:00Z

@cferreiragonz Test BlackboxTests_DDS_PIM.MockedInterfaces.DDSDiscoveryNoInterfaces.DS_listens_on_any_if_there_are_no_interfaces failed on Windows

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2025-06-06T06:31:56Z

@cferreiragonz Test BlackboxTests_DDS_PIM.MockedInterfaces.DDSDiscoveryNoInterfaces.DS_listens_on_any_if_there_are_no_interfaces failed on Windows

I have refactored the test (called dds.commmunication.ds_init_with_no_interfaces now) and it relies on docker. Let's wait for new CI

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz · 2025-06-16T12:36:48Z

@Mergifyio backport 3.2.x 2.14.x

mergify · 2025-06-16T12:37:03Z

backport 3.2.x 2.14.x

✅ Backports have been created

Details

#5876 [23248] Fix DS initialization on "any" if no interfaces are available (backport #5850) has been created for branch 3.2.x
#5877 [23248] Fix DS initialization on "any" if no interfaces are available (backport #5850) has been created for branch 2.14.x

* Refs #23248: Add regression test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Use localhost if no interfaces are found Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Fix permissions of .bash Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: NITs Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 4e6a68f)

…#5876) * Refs #23248: Add regression test * Refs #23248: Use localhost if no interfaces are found * Refs #23248: Fix permissions of .bash * Refs #23248: NITs --------- (cherry picked from commit 4e6a68f) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

* Refs #23248: Add regression test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Use localhost if no interfaces are found Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Fix permissions of .bash Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: NITs Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 4e6a68f)

…#5877) * Fix DS initialization on "any" if no interfaces are available (#5850) * Refs #23248: Add regression test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Use localhost if no interfaces are found Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: Fix permissions of .bash Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23248: NITs Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 4e6a68f) * Add GUID to DS test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>

cferreiragonz added this to the v3.2.3 milestone Jun 4, 2025

cferreiragonz requested a review from richiprosima June 4, 2025 08:57

github-actions Bot added the ci-pending PR which CI is running label Jun 4, 2025

cferreiragonz requested review from richiprosima and removed request for richiprosima June 4, 2025 14:45

cferreiragonz force-pushed the bug/23248 branch from 600e158 to 8eaf89e Compare June 5, 2025 05:37

cferreiragonz requested a review from richiprosima June 5, 2025 05:37

cferreiragonz added the needs-review PR that is ready to be reviewed label Jun 5, 2025

cferreiragonz added 2 commits June 6, 2025 08:23

Refs #23248: Add regression test

a19054c

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Refs #23248: Use localhost if no interfaces are found

43b11eb

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz force-pushed the bug/23248 branch from 8eaf89e to 43b11eb Compare June 6, 2025 06:24

cferreiragonz requested review from richiprosima and removed request for richiprosima June 6, 2025 06:26

rsanchez15 modified the milestones: v3.2.3, v3.3.0 Jun 9, 2025

Refs #23248: Fix permissions of .bash

6b51437

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

cferreiragonz requested review from richiprosima and removed request for richiprosima June 12, 2025 06:30

cferreiragonz removed the ci-pending PR which CI is running label Jun 12, 2025

Refs #23248: NITs

520d5ff

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

Carlosespicur approved these changes Jun 16, 2025

View reviewed changes

Carlosespicur self-requested a review June 16, 2025 05:27

github-actions Bot added the ci-pending PR which CI is running label Jun 16, 2025

cferreiragonz removed the needs-review PR that is ready to be reviewed label Jun 16, 2025

cferreiragonz merged commit 4e6a68f into master Jun 16, 2025
17 checks passed

cferreiragonz deleted the bug/23248 branch June 16, 2025 12:35

This was referenced Jun 16, 2025

[23248] Fix DS initialization on "any" if no interfaces are available (backport #5850) #5876

Merged

[23248] Fix DS initialization on "any" if no interfaces are available (backport #5850) #5877

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[23248] Fix DS initialization on "any" if no interfaces are available#5850

[23248] Fix DS initialization on "any" if no interfaces are available#5850
cferreiragonz merged 4 commits into
masterfrom
bug/23248

cferreiragonz commented Jun 4, 2025 •

edited

Loading

Uh oh!

MiguelCompany commented Jun 6, 2025

Uh oh!

cferreiragonz commented Jun 6, 2025

Uh oh!

Uh oh!

cferreiragonz commented Jun 16, 2025

Uh oh!

mergify Bot commented Jun 16, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

cferreiragonz commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

MiguelCompany commented Jun 6, 2025

Uh oh!

cferreiragonz commented Jun 6, 2025

Uh oh!

Uh oh!

cferreiragonz commented Jun 16, 2025

Uh oh!

mergify Bot commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cferreiragonz commented Jun 4, 2025 •

edited

Loading

mergify Bot commented Jun 16, 2025 •

edited

Loading