[22593] Include all example tests in windows CI#5851
Merged
Conversation
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
June 10, 2025 14:50
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
June 11, 2025 07:08
rsanchez15
requested changes
Jun 12, 2025
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
June 24, 2025 07:23
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
June 24, 2025 07:26
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
June 24, 2025 12:19
…st files, split configuration example and expose all example tests in windows Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Contributor
Author
|
In the |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…mp fails Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
rsanchez15
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes all the remaining examples into the windows ci testing.
Some considerations worth mentioning:
test_configurationwas splitted into3suite of tests in order not to exceed the300timeout seconds configured in colcon.network_mode: host, some examples were refactored to use customnetworkwith fixed ips (for instance, thediscovery_serverexample one)subprocess.check_outputdoes not properly work in Windows, when thetimeoutexpires, subprocesses are not killed. This led me to also disable thetimeouttest cases for some of the example tests.Publishersto force waiting forackin the first sample and mitigate flakiness.Note: This PR should be merged after
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist