Skip to content

[22593] Include all example tests in windows CI#5851

Merged
rsanchez15 merged 13 commits into
masterfrom
feature/22593
Jun 27, 2025
Merged

[22593] Include all example tests in windows CI#5851
rsanchez15 merged 13 commits into
masterfrom
feature/22593

Conversation

@Mario-DL

@Mario-DL Mario-DL commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Description

This PR includes all the remaining examples into the windows ci testing.
Some considerations worth mentioning:

  • test_configuration was splitted into 3 suite of tests in order not to exceed the 300 timeout seconds configured in colcon.
  • IPv6 test cases were disabled in both Windows and Ubuntu. Windows does not support it and Docker in Ubuntu CI supports only the ipv6 localhost (I tried to enable the experimental features but gave error). Since Docker in Windows neither supports network_mode: host, some examples were refactored to use custom network with fixed ips (for instance, the discovery_server example one)
  • Some test cases were disabled in some examples in windows to avoid flakiness. Specially those making use of SHM or DataSharing among dockers. The issue will keep being being investigated in a follow up PR.
  • The Python subprocess.check_output does not properly work in Windows, when the timeout expires, subprocesses are not killed. This led me to also disable the timeout test cases for some of the example tests.
  • Some extra additions were made to the Publishers to force waiting for ack in the first sample and mitigate flakiness.

Note: This PR should be merged after

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.3 milestone Jun 4, 2025
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 4, 2025 10:36
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 4, 2025
@Mario-DL Mario-DL modified the milestones: v3.2.3, v3.3.0 Jun 4, 2025
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 10, 2025 14:50
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 11, 2025 07:08
Comment thread examples/cpp/benchmark/PublisherApp.cpp
@Mario-DL
Mario-DL requested review from rsanchez15 and removed request for rsanchez15 June 16, 2025 07:51
@Mario-DL
Mario-DL requested review from rsanchez15 and removed request for rsanchez15 June 17, 2025 06:26
@Mario-DL
Mario-DL requested review from rsanchez15 and removed request for rsanchez15 June 17, 2025 06:35
Base automatically changed from ci/23253 to master June 17, 2025 10:43
@rsanchez15
rsanchez15 self-requested a review June 17, 2025 10:45
@Mario-DL
Mario-DL requested review from rsanchez15 and removed request for rsanchez15 June 17, 2025 10:47
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 24, 2025 07:23
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 24, 2025 07:26
@Mario-DL
Mario-DL requested review from richiprosima and removed request for richiprosima June 24, 2025 12:19
Mario-DL added 3 commits June 25, 2025 10:54
…st files, split configuration example and expose all example tests in windows

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL

Copy link
Copy Markdown
Contributor Author

In the delivery_mechanisms example I forced to ack the first and the last sample (just if samples >0). Hopefully it completely solves the flakiness of the test. In my local I run it 20 times without failure 🤞🏻

@Mario-DL
Mario-DL requested review from rsanchez15 and removed request for rsanchez15 June 25, 2025 10:55
Mario-DL added 10 commits June 25, 2025 17:50
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…mp fails

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants