[23213] Add localhost capability only to UDP & TCP transports (backport #5864)#5869
Merged
Conversation
Contributor
Author
|
Cherry-pick of 401ccad has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
juanlofer-eprosima
force-pushed
the
mergify/bp/2.14.x/pr-5864
branch
from
June 12, 2025 06:06
2fec630 to
205e745
Compare
juanlofer-eprosima
requested review from
MiguelCompany
and removed request for
MiguelCompany
June 12, 2025 06:06
juanlofer-eprosima
requested review from
MiguelCompany
and removed request for
MiguelCompany
June 12, 2025 09:48
MiguelCompany
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #3733 introduced a new proxy parameter (network configuration) used to transmit in discovery the information of whether transformation of locators to localhost can be applied for each transport kind. In this parameter, the value of each possible locator kind (powers of 2) is used to conform the binary mask corresponding to the network configuration parameter. However, in PR #5116 the value of shared memory kind was modified in a way that may pollute the values corresponding to UDP transport kinds.
This PR solves the issue by only setting the corresponding localhost network configuration for transports supporting it (UDP and TCP). It also adds an extra assertion verifying the bit operation can be safely done.
@Mergifyio backport 3.2.x 2.14.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5864 done by [Mergify](https://mergify.com).