[23267] Add `uncrustify` to Github CI by Mario-DL · Pull Request #5878 · eProsima/Fast-DDS

Mario-DL · 2025-06-17T14:01:38Z

Description

This PR adds uncrustify to Github CI.

After this PR gets merged, the corresponding changes in the repository management checks should be performed as well as disabling fastdds_github_uncrusitfy job from jenkins

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL · 2025-06-17T14:25:58Z

I will leave the PR as it is for the reviewer to check that the results are the expected in case of failure

MiguelCompany · 2025-06-18T15:25:25Z

@Mergifyio rebase

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

mergify · 2025-06-18T15:25:38Z

rebase

✅ Branch has been successfully rebased

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

MiguelCompany · 2025-06-19T06:04:28Z

@Mergifyio backport 3.2.x 2.14.x 2.6.x

mergify · 2025-06-19T06:04:35Z

backport 3.2.x 2.14.x 2.6.x

✅ Backports have been created

Details

#5886 [23267] Add uncrustify to Github CI (backport #5878) has been created for branch 3.2.x
#5887 [23267] Add uncrustify to Github CI (backport #5878) has been created for branch 2.14.x
#5888 [23267] Add uncrustify to Github CI (backport #5878) has been created for branch 2.6.x

* Refs #23267: Add uncrustify to ci Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #23267: Apply Miguels suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #23267: Apply second suggestion Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 6bae07c)

* Refs #23267: Add uncrustify to ci * Refs #23267: Apply Miguels suggestion * Refs #23267: Apply second suggestion --------- (cherry picked from commit 6bae07c) Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

Mario-DL added this to the v3.3.0 milestone Jun 17, 2025

Mario-DL requested review from richiprosima and removed request for richiprosima June 17, 2025 14:02

github-actions Bot added the ci-pending PR which CI is running label Jun 17, 2025

Mario-DL requested review from richiprosima and removed request for richiprosima June 17, 2025 14:05

Mario-DL force-pushed the ci/23267 branch 2 times, most recently from 989556f to 9482027 Compare June 17, 2025 14:16

Mario-DL requested review from richiprosima and removed request for richiprosima June 17, 2025 14:16

Mario-DL force-pushed the ci/23267 branch from 9482027 to 0a4e7a3 Compare June 17, 2025 14:18

Mario-DL requested review from richiprosima and removed request for richiprosima June 17, 2025 14:18

Mario-DL force-pushed the ci/23267 branch from 16cee9b to 9c9c9b8 Compare June 17, 2025 14:24

Mario-DL requested review from richiprosima and removed request for richiprosima June 17, 2025 14:25

Mario-DL marked this pull request as ready for review June 17, 2025 14:26

MiguelCompany requested changes Jun 18, 2025

View reviewed changes

Comment thread .github/workflows/linters.yml Outdated

Mario-DL force-pushed the ci/23267 branch from 9c9c9b8 to f3ec71b Compare June 18, 2025 14:53

Mario-DL requested review from MiguelCompany and removed request for MiguelCompany June 18, 2025 14:53

Mario-DL added no-test Skip CI tests if PR marked with this label and removed no-test Skip CI tests if PR marked with this label labels Jun 18, 2025

MiguelCompany self-requested a review June 18, 2025 15:23

Mario-DL added 2 commits June 18, 2025 15:25

Refs #23267: Add uncrustify to ci

d7fc603

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #23267: Apply Miguels suggestion

751664e

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

MiguelCompany force-pushed the ci/23267 branch from f3ec71b to 751664e Compare June 18, 2025 15:25

MiguelCompany requested review from richiprosima June 18, 2025 15:27

MiguelCompany requested changes Jun 19, 2025

View reviewed changes

Comment thread .github/workflows/linters.yml Outdated

MiguelCompany previously approved these changes Jun 19, 2025

View reviewed changes

Refs #23267: Apply second suggestion

75b6052

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL dismissed MiguelCompany’s stale review via 75b6052 June 19, 2025 05:53

Mario-DL force-pushed the ci/23267 branch from 29aea0d to 75b6052 Compare June 19, 2025 05:53

MiguelCompany approved these changes Jun 19, 2025

View reviewed changes

MiguelCompany merged commit 6bae07c into master Jun 19, 2025
4 checks passed

MiguelCompany deleted the ci/23267 branch June 19, 2025 06:03

mergify Bot mentioned this pull request Jun 19, 2025

[23267] Add uncrustify to Github CI (backport #5878) #5886

Merged

9 tasks

mergify Bot mentioned this pull request Jun 19, 2025

[23267] Add uncrustify to Github CI (backport #5878) #5887

Merged

9 tasks

mergify Bot mentioned this pull request Jun 19, 2025

[23267] Add uncrustify to Github CI (backport #5878) #5888

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[23267] Add `uncrustify` to Github CI#5878

[23267] Add `uncrustify` to Github CI#5878
MiguelCompany merged 3 commits into
masterfrom
ci/23267

Mario-DL commented Jun 17, 2025 •

edited by MiguelCompany

Loading

Uh oh!

Mario-DL commented Jun 17, 2025

Uh oh!

Uh oh!

MiguelCompany commented Jun 18, 2025

Uh oh!

mergify Bot commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Jun 19, 2025

Uh oh!

mergify Bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Mario-DL commented Jun 17, 2025 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Mario-DL commented Jun 17, 2025

Uh oh!

Uh oh!

MiguelCompany commented Jun 18, 2025

Uh oh!

mergify Bot commented Jun 18, 2025

✅ Branch has been successfully rebased

Uh oh!

Uh oh!

Uh oh!

MiguelCompany commented Jun 19, 2025

Uh oh!

mergify Bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Mario-DL commented Jun 17, 2025 •

edited by MiguelCompany

Loading

mergify Bot commented Jun 19, 2025 •

edited

Loading