Skip to content

[23346] Add get_complete_type_object to ITypeObjectRegistry#5885

Merged
MiguelCompany merged 7 commits into
masterfrom
feature/23346
Jun 20, 2025
Merged

[23346] Add get_complete_type_object to ITypeObjectRegistry#5885
MiguelCompany merged 7 commits into
masterfrom
feature/23346

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jun 18, 2025

Copy link
Copy Markdown
Member

Description

This adds a new getter to ITypeObjectRegistry that allows getting a CompleteTypeObject from a registered TypeIdentifierPair.

This is the follow-up that we decided to do in #5867 (comment), so the related code in DDSFilterFactory has also been updated.

It also exports two methods and adds unit tests for them.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 18, 2025
…ing tests.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany requested a review from Mario-DL June 19, 2025 07:17
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 19, 2025
Comment thread src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterFactory.cpp
Mario-DL
Mario-DL previously approved these changes Jun 19, 2025

@Mario-DL Mario-DL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany merged commit 7f4ce7d into master Jun 20, 2025
4 checks passed
@MiguelCompany
MiguelCompany deleted the feature/23346 branch June 20, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants