[23355] Add VS143 toolset#5910
Merged
Merged
Conversation
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Contributor
Author
|
After merge, it is required to update the CI requirements to remove the v141 and add v143 @rsanchez15 |
MiguelCompany
requested changes
Jul 1, 2025
MiguelCompany
left a comment
MiguelCompany
left a comment
Member
There was a problem hiding this comment.
We'll have to update the PLATFORM_SUPPORT.md, and also the documentation
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Contributor
Author
|
Related documentation has been updated here: eProsima/Fast-DDS-docs#1092 |
EugenioCollado
requested review from
MiguelCompany
and removed request for
richiprosima
July 1, 2025 10:41
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
MiguelCompany
requested changes
Jul 1, 2025
| matrix: | ||
| vs-toolset: | ||
| - 'v142' | ||
| - 'v143' |
Member
There was a problem hiding this comment.
Please add the toolset to the name of the test job in line 157
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
MiguelCompany
self-requested a review
July 1, 2025 15:20
Contributor
Author
|
@Mergifyio backport 3.2.x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Use VS143 toolset Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Platform doc update Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Upload artifact Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Added toolset version to job name Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> (cherry picked from commit 9868b8b)
13 tasks
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Use VS143 toolset * Platform doc update * Upload artifact * Added toolset version to job name --------- (cherry picked from commit 9868b8b) Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> Co-authored-by: EugenioCollado <121509066+EugenioCollado@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Windows GitHub Action Runner toolsets, including v143 (VS2022).
@Mergifyio backport 3.2.x (do NOT backport to 2.14 as this update has been included in #5909)
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist