Skip to content

[23882] Make DomainParticipant::get_instance_handle return by value#6149

Merged
MiguelCompany merged 1 commit into
masterfrom
feature/23882
Jan 15, 2026
Merged

[23882] Make DomainParticipant::get_instance_handle return by value#6149
MiguelCompany merged 1 commit into
masterfrom
feature/23882

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Nov 5, 2025

Copy link
Copy Markdown
Member

Description

This solves the same as #6148 with a different approach, which breaks ABI.
It changes DomainParticipant::get_instance_handle to return by value, and constructs the InstanceHandle_t from the participant's GUID on the fly.

This is similar to what is done for DataWriter and DataReader.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.5.0 milestone Nov 5, 2025
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 5, 2025
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima November 5, 2025 09:49
@github-actions github-actions Bot added the ci-pending PR which CI is running label Nov 5, 2025
@MiguelCompany MiguelCompany added blocked-till-branch-out and removed ci-pending PR which CI is running labels Nov 5, 2025
…value.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jan 8, 2026
@MiguelCompany MiguelCompany removed the no-test Skip CI tests if PR marked with this label label Jan 8, 2026
@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima January 8, 2026 13:35
@mergify

mergify Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

🧪 CI Insights

Here's what we observed from your CI run for 8a953c7.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, failing tests are unrelated

@MiguelCompany
MiguelCompany merged commit d84c90c into master Jan 15, 2026
47 of 49 checks passed
@MiguelCompany
MiguelCompany deleted the feature/23882 branch January 15, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants