Skip to content

[24126] Refactor Secure Discovery Server#6295

Merged
MiguelCompany merged 13 commits into
masterfrom
feature/refactor-secure-ds
Feb 9, 2026
Merged

[24126] Refactor Secure Discovery Server#6295
MiguelCompany merged 13 commits into
masterfrom
feature/refactor-secure-ds

Conversation

@raulojeda22

@raulojeda22 raulojeda22 commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Description

Refactor Discovery Server with security in Fast DDS

  • Refactor PDPServer, PDPClient and FakeWriter
  • Remove unnecessary tests
  • Add a test for the new behavior

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@raulojeda22 raulojeda22 added this to the v3.5.0 milestone Feb 3, 2026
@raulojeda22
raulojeda22 requested review from richiprosima and removed request for richiprosima February 3, 2026 14:48
@github-actions github-actions Bot added the ci-pending PR which CI is running label Feb 3, 2026
@mergify

mergify Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

🧪 CI Insights

Here's what we observed from your CI run for bd61d38.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Ubuntu CI ubuntu-ci / fastdds_test (RelWithDebInfo) Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View
windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 0 View View

@raulojeda22
raulojeda22 requested review from richiprosima and removed request for richiprosima February 4, 2026 10:18
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>
@raulojeda22
raulojeda22 force-pushed the feature/refactor-secure-ds branch from 29ac7bf to 06c6092 Compare February 6, 2026 07:36
Signed-off-by: Raül <raulojeda@eprosima.com>
Comment thread src/cpp/rtps/builtin/discovery/participant/PDPClient.cpp Outdated
Comment thread src/cpp/rtps/builtin/discovery/participant/PDPServer.cpp Outdated
Comment thread test/dds/communication/security/test_secure_ds_disabled.py
raulojeda22 and others added 2 commits February 6, 2026 10:53
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Raül Ojeda Gandia <raulojeda@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Raül Ojeda Gandia <raulojeda@eprosima.com>
Signed-off-by: Raül <raulojeda@eprosima.com>

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany
MiguelCompany merged commit 59c6e75 into master Feb 9, 2026
22 of 26 checks passed
@MiguelCompany
MiguelCompany deleted the feature/refactor-secure-ds branch February 9, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants