Removing need for RegEx when expanding ENV variables#6312
Open
FracturedShader wants to merge 1 commit into
Open
Removing need for RegEx when expanding ENV variables#6312FracturedShader wants to merge 1 commit into
FracturedShader wants to merge 1 commit into
Conversation
When starting up several programs with STATIC EDP on embedded hardware, this routine dominates the startup time due to the RegEx recompilation and `std::regex` internally being locale aware. Especially when the EDP XML is fairly large. This work replaces the RegEx with a small finite state machine that does a single linear pass over the input. Results from `perf` show this significantly reduces parsing time (as all text of interest is passed through this method). Signed-off-by: Robert Plante <RobertDPlante@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting up several programs with STATIC EDP on embedded hardware, this routine dominates the startup time due to the RegEx recompilation and
std::regexinternally being locale aware. Especially when the EDP XML is fairly large.This work replaces the RegEx with a small finite state machine that does a single linear pass over the input. Results from
perfshow this significantly reduces parsing time (as all text of interest is passed through this method).Description
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist