Backport #5796: Add missing #include <cstdint> in DDSSQLFilter headers to 2.6.x#6332
Open
PavelGuzenfeld wants to merge 1 commit into
Open
Conversation
GCC 13+ and GCC 15+ no longer provide transitive includes for fixed-width integer types (uint8_t, uint32_t, etc.). The DDSSQLFilter headers use these types without explicitly including <cstdint>, causing compilation failures with modern compilers. This is a backport of the fix from PR eProsima#5796 (which was applied to master, 3.1.x, 2.14.x, and 2.10.x) to the 2.6.x branch. ROS 2 Humble depends on Fast-DDS 2.6.x and is supported until 2027. Refs: eProsima#5790 Signed-off-by: Pavel Guzenfeld <67074795+PavelGuzenfeld@users.noreply.github.com>
Author
|
Ping for review — no activity since submission. Happy to rebase or adjust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of PR #5796 to the
2.6.xbranch.GCC 13+ and GCC 15+ no longer provide transitive includes for fixed-width integer types (
uint8_t,uint32_t, etc.). The following DDSSQLFilter headers use these types without explicitly including<cstdint>, causing compilation failures:DDSFilterCompoundCondition.hpp— usesuint8_tinOperationKindenum and member variableDDSFilterPredicate.hpp— usesuint8_tinOperationKindenumDDSFilterValue.hpp— usesuint64_t,int64_tin union membersThis fix was already applied to
master,3.1.x,2.14.x, and2.10.xbut the2.6.xbackport was skipped. Since ROS 2 Humble depends on Fast-DDS 2.6.x and is supported until 2027, this backport is important for users building with modern compilers.Changes
Added
#include <cstdint>to:src/cpp/fastdds/topic/DDSSQLFilter/DDSFilterCompoundCondition.hppsrc/cpp/fastdds/topic/DDSSQLFilter/DDSFilterPredicate.hppsrc/cpp/fastdds/topic/DDSSQLFilter/DDSFilterValue.hppReferences