Skip to content

[24178] Fix failure setting default locator in empty multicast locator list#6351

Merged
rsanchez15 merged 11 commits into
masterfrom
hotfix/empty-multicast-locator-list
May 6, 2026
Merged

[24178] Fix failure setting default locator in empty multicast locator list#6351
rsanchez15 merged 11 commits into
masterfrom
hotfix/empty-multicast-locator-list

Conversation

@emiliocuestaf

@emiliocuestaf emiliocuestaf commented Apr 1, 2026 •
edited by cferreiragonz
Loading

Copy link
Copy Markdown
Contributor

Fix failure setting default locator in empty multicast locator list

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [N/A] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@emiliocuestaf
Fix failure when setting default locator in empty multicast locator l…
20a2b09 
…ists. Only the port was being set to default, IP was initialized to 0

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@github-actions github-actions Bot added the ci-pending PR which CI is running label Apr 1, 2026
@emiliocuestaf
Trying a cleaner approach
546fcf1 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
emiliocuestaf requested review from richiprosima and removed request for richiprosima April 1, 2026 15:41
@emiliocuestaf
Replicate unicast stack of functions to treat default addresses
b10e15c 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
emiliocuestaf requested review from richiprosima and removed request for richiprosima April 6, 2026 08:42
@emiliocuestaf
Uncrustify
44b88cd 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
emiliocuestaf requested review from richiprosima and removed request for richiprosima April 6, 2026 08:43
@emiliocuestaf emiliocuestaf added this to the v3.6.1 milestone Apr 6, 2026
cferreiragonz
cferreiragonz requested changes Apr 7, 2026
View reviewed changes
Comment thread src/cpp/rtps/network/NetworkFactory.hpp
Comment thread include/fastdds/rtps/transport/TransportInterface.hpp Outdated
Comment thread src/cpp/rtps/transport/UDPTransportInterface.cpp Outdated
Comment thread src/cpp/rtps/transport/UDPTransportInterface.cpp Outdated
Comment thread test/unittest/rtps/network/NetworkFactoryTests.cpp Outdated
Comment thread test/unittest/rtps/network/NetworkFactoryTests.cpp Outdated
Comment thread src/cpp/rtps/transport/TCPTransportInterface.cpp Outdated
Comment thread src/cpp/rtps/transport/shared_mem/SharedMemTransport.cpp Outdated
emiliocuestaf and others added 3 commits April 7, 2026 12:55
@emiliocuestaf @cferreiragonz
Batch of suggestion from code review
d7b89b8 
Co-authored-by: Carlos Ferreira González <carloos.499@gmail.com>
Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com>
@emiliocuestaf
Apply review
8737684 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
Uncrustify
f73bcd4 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
emiliocuestaf requested review from richiprosima and removed request for richiprosima April 7, 2026 13:05
@MiguelCompany MiguelCompany modified the milestones: v3.6.1, v3.6.2 Apr 8, 2026
cferreiragonz
cferreiragonz requested changes Apr 8, 2026
View reviewed changes
Comment thread src/cpp/rtps/transport/shared_mem/SharedMemTransport.cpp Outdated
Comment thread src/cpp/rtps/transport/shared_mem/SharedMemTransport.cpp Outdated
@emiliocuestaf
Fix compilation issue
3c20725 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
emiliocuestaf requested review from richiprosima and removed request for richiprosima April 8, 2026 16:01
@cferreiragonz
cferreiragonz removed the request for review from richiprosima April 9, 2026 05:22
cferreiragonz
cferreiragonz previously approved these changes Apr 9, 2026
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz
cferreiragonz marked this pull request as ready for review April 9, 2026 05:23
@cferreiragonz cferreiragonz removed the ci-pending PR which CI is running label Apr 9, 2026
@cferreiragonz cferreiragonz added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 9, 2026
@emiliocuestaf emiliocuestaf removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 9, 2026
@emiliocuestaf
Avoid ABI/API break by adding new private interface
4aa8f99 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@github-actions github-actions Bot added the ci-pending PR which CI is running label Apr 20, 2026
@emiliocuestaf
Fix cmake in tests
13696e9 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@MiguelCompany
MiguelCompany self-requested a review April 22, 2026 06:18
cferreiragonz
cferreiragonz requested changes Apr 24, 2026
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small aesthetic changes

Comment thread src/cpp/rtps/transport/MulticastTransportInterface.h Outdated
Comment thread src/cpp/rtps/transport/MulticastTransportInterface.h Outdated
Comment thread src/cpp/rtps/transport/MulticastTransportInterface.hpp
Comment thread src/cpp/rtps/transport/MulticastTransportInterface.cpp Outdated
Comment thread src/cpp/rtps/transport/UDPTransportInterface.h Outdated
Comment thread test/unittest/statistics/dds/CMakeLists.txt Outdated
Comment thread test/unittest/statistics/dds/CMakeLists.txt Outdated
Comment thread test/unittest/statistics/rtps/CMakeLists.txt Outdated
Comment thread test/unittest/transport/CMakeLists.txt Outdated
Comment thread test/unittest/transport/CMakeLists.txt Outdated
@emiliocuestaf
Apply revision
70b761b 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@cferreiragonz
cferreiragonz self-requested a review April 24, 2026 10:21
cferreiragonz
cferreiragonz approved these changes Apr 24, 2026
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz
cferreiragonz removed the request for review from richiprosima April 24, 2026 10:21
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima May 4, 2026 08:13
@rsanchez15
rsanchez15 merged commit 43d6be7 into master May 6, 2026
63 of 75 checks passed
@rsanchez15
rsanchez15 deleted the hotfix/empty-multicast-locator-list branch May 6, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes
@MiguelCompany MiguelCompany Awaiting requested review from MiguelCompany

Assignees

No one assigned

Labels

ci-pending PR which CI is running fast dds pro

Projects

None yet

Milestone

v3.6.2.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

4 participants

@emiliocuestaf @cferreiragonz @rsanchez15 @MiguelCompany