Skip to content

[24379] Fix TCP reconnection with listening port#6378

Merged
MiguelCompany merged 6 commits into
masterfrom
fix_tcp_reconnection_w_list_port
May 6, 2026
Merged

[24379] Fix TCP reconnection with listening port#6378
MiguelCompany merged 6 commits into
masterfrom
fix_tcp_reconnection_w_list_port

Conversation

@cferreiragonz

@cferreiragonz cferreiragonz commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes a bug in which a TCP server wrongly cleans up its TCP client participants if they have a listening port defined.

@Mergifyio backport 3.4.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
…s using it

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added this to the v3.6.2 milestone Apr 27, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Apr 27, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima April 28, 2026 10:52
… different channel

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima April 28, 2026 13:53

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, and we are good to go.

Comment thread include/fastdds/rtps/transport/ChainingTransport.hpp Outdated
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@MiguelCompany
MiguelCompany merged commit 24ab81e into master May 6, 2026
22 of 27 checks passed
@MiguelCompany
MiguelCompany deleted the fix_tcp_reconnection_w_list_port branch May 6, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants