[23767] Fix data races on DataWriterImpl qos access

[ZakariaTalbi]

Description

This PR attempts to fix data races on DataWriterImpl::qos_, where mainly the enable() and set_qos functions accessed the element simultaneously.

Added a new qos_mutex_ that guards qos_ and writer_. A concurrency regression test has also been included.

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• Any new/modified methods have been properly documented using Doxygen.
• N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A: New feature has been added to the versions.md file (if applicable).
• N/A: New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[MiguelCompany]

I have not found the data race mentioned in the description inside the reports of the TSAN nightly jobs. This means that this PR needs a regression test

[ZakariaTalbi]

I have not found the data race mentioned in the description inside the reports of the TSAN nightly jobs. This means that this PR needs a regression test

I want to believe ConcurrentSetQosVsGetQos already tests the data race when run with TSAN meta.

[MiguelCompany]

I want to believe ConcurrentSetQosVsGetQos already tests the data race when run with TSAN meta.

You are right, it should!
I launched TSAN on the first commit of this PR here. Let's see if the data races are reported.

[MiguelCompany]

@Mergifyio backport 3.2.x 2.14.x

[mergify]

backport 3.2.x 2.14.x

✅ Backports have been created

Details

• #6423 [23767] Fix data races on DataWriterImpl qos access (backport #6409) has been created for branch 3.2.x but encountered conflicts

Cherry-pick of 9a31251 has failed:

On branch mergify/bp/3.2.x/pr-6409
Your branch is up to date with 'origin/3.2.x'.

You are currently cherry-picking commit 9a3125144.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/fastdds/publisher/DataWriter.cpp
	modified:   src/cpp/fastdds/publisher/DataWriterImpl.hpp
	modified:   test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests/mock/fastdds/publisher/DataWriterImpl.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/fastdds/publisher/DataWriterImpl.cpp
	both modified:   test/unittest/dds/publisher/DataWriterTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

• #6424 [23767] Fix data races on DataWriterImpl qos access (backport #6409) has been created for branch 2.14.x but encountered conflicts

Cherry-pick of 9a31251 has failed:

On branch mergify/bp/2.14.x/pr-6409
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 9a3125144.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/cpp/fastdds/publisher/DataWriterImpl.hpp
	modified:   test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests/mock/fastdds/publisher/DataWriterImpl.hpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/cpp/fastdds/publisher/DataWriter.cpp
	both modified:   src/cpp/fastdds/publisher/DataWriterImpl.cpp
	both modified:   test/unittest/dds/publisher/DataWriterTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally