Skip to content

[#24584] Fix TypeObjectRegistry null pass to a callee#6415

Merged
richiware merged 4 commits into
masterfrom
fix/macos-type_obj_reg
Jun 10, 2026
Merged

[#24584] Fix TypeObjectRegistry null pass to a callee#6415
richiware merged 4 commits into
masterfrom
fix/macos-type_obj_reg

Conversation

@Danipiza

@Danipiza Danipiza commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

Issues when building natively on macOS (aarch64-darwin) with clang 21 + libc++ from Nix.

  • TypeObjectRegistry.cpp:2620error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull].
    ...build_annotation_parameter_value(!value.empty() ? value : 0);

I was able to patch this by replacing 0 with empty str literal.

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Danipiza added 2 commits June 2, 2026 09:46
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza
Danipiza force-pushed the fix/macos-type_obj_reg branch from fe600af to 54c41d7 Compare June 2, 2026 07:46
@Danipiza
Danipiza requested a review from ZakariaTalbi June 2, 2026 08:50
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 2, 2026
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza
Danipiza requested review from ZakariaTalbi and removed request for ZakariaTalbi June 2, 2026 13:30
@Danipiza Danipiza added this to the v3.6.2 milestone Jun 2, 2026
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza
Danipiza requested a review from richiprosima June 3, 2026 16:11

@ZakariaTalbi ZakariaTalbi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
richiware merged commit e1a42f3 into master Jun 10, 2026
35 of 39 checks passed
@richiware
richiware deleted the fix/macos-type_obj_reg branch June 10, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants