Skip to content

fix microcontroller no real bool type issue#387

Open
engr-ping wants to merge 1 commit into
eProsima:masterfrom
engr-ping:feature/serialize_bool
Open

fix microcontroller no real bool type issue#387
engr-ping wants to merge 1 commit into
eProsima:masterfrom
engr-ping:feature/serialize_bool

Conversation

@engr-ping

Copy link
Copy Markdown

fix issue eProsima/Micro-XRCE-DDS#173
SOC need real bool type,But MCU does not have real bool type.
in MCU,bool = uint8

@richiprosima

Copy link
Copy Markdown
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

Signed-off-by: clipping <clippinglp@qq.com>
@engr-ping
engr-ping force-pushed the feature/serialize_bool branch from 2a0aa06 to df72ddb Compare June 3, 2024 03:28
@richiprosima

Copy link
Copy Markdown
Contributor

Build status:

  • Linux Build Status
  • Windows Build Status

@pablogs9

pablogs9 commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

I would prefer to have some kind of check in ucdr_serialize_bool that serializes an 0x01 when arg != 0, is that possible to modify this PR to that approach?

@engr-ping

Copy link
Copy Markdown
Author

yes , but i would prefer to change ucdr_serialize_bool when this function defined,look:eProsima/Micro-CDR#75
Whether or not the caller makes an arg!=0 judgment, we can avoid this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants