Skip to content

[#24313] Fix Participant Configuration domain id upper bound (99 -> 232) (backport #238)#241

Merged
Danipiza merged 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-238
Mar 31, 2026
Merged

[#24313] Fix Participant Configuration domain id upper bound (99 -> 232) (backport #238)#241
Danipiza merged 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-238

Conversation

@mergify

@mergify mergify Bot commented Mar 31, 2026

Copy link
Copy Markdown

Description

This change fixes the domain ID range in the Participant Configuration dialog.

Updated spin_domainId in forms/participantdialog.ui to set an explicit maximum of 232.
Previously, no maximum was set, so Qt used its default 99.

@Mergifyio backport 2.6.x 2.14.x 3.2.x 3.3.x 3.4.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • Changes do not break current interoperability.

  • New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #238 done by [Mergify](https://mergify.com).

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza
Danipiza force-pushed the mergify/bp/2.14.x/pr-238 branch from b355dc7 to 35d507a Compare March 31, 2026 07:55
@Danipiza
Danipiza requested a review from richiprosima March 31, 2026 07:56
@github-actions github-actions Bot added the ci-pending PR which CI is running label Mar 31, 2026
@Danipiza
Danipiza requested review from Danipiza and removed request for richiprosima March 31, 2026 08:05

@Danipiza Danipiza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza merged commit 487a9fd into 2.14.x Mar 31, 2026
7 of 9 checks passed
@Danipiza
Danipiza deleted the mergify/bp/2.14.x/pr-238 branch March 31, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant