Skip to content

[#25465] Support multi-select endpoint deletion and fixed a typo#257

Merged
Danipiza merged 1 commit into
masterfrom
feature/multiple-lines
Jun 25, 2026
Merged

[#25465] Support multi-select endpoint deletion and fixed a typo#257
Danipiza merged 1 commit into
masterfrom
feature/multiple-lines

Conversation

@Danipiza

@Danipiza Danipiza commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

This PR improves endpoint management in the Qt UI by allowing multiple endpoints to be selected and removed in one action.

It also fixes the Delete Enpoint typo in the context menu label.

Local steps to test it

  1. Single-click selects one endpoint row
  2. Press keyboard key "Ctrl"/"Shift"
    2.1 Ctrl + click adds or removes individual rows from the selection
    2.2 Shift + click selects a contiguous row range
    2.3 Shift + <up/down> adds or removes individual adjacent row from the selection
  3. Deletion
    3.1 Pressing Delete removes all selected endpoints
    3.2 Right-clicking a selected row keeps the current multi-selection

Documentation PR

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Changes do not break current interoperability.
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

…int' typo

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza requested a review from richiprosima June 24, 2026 07:37
@github-actions github-actions Bot added ci-pending PR which CI is running labels Jun 24, 2026
@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Danipiza Danipiza added this to the v3.6.2 milestone Jun 25, 2026
@Danipiza
Danipiza merged commit 2113d28 into master Jun 25, 2026
7 of 8 checks passed
@Danipiza
Danipiza deleted the feature/multiple-lines branch June 25, 2026 09:49
@Danipiza

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport 3.2.x 2.14.x

@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown

backport 3.2.x 2.14.x

✅ Backports have been created

Details

Cherry-pick of 2113d28 has failed:

On branch mergify/bp/3.2.x/pr-257
Your branch is up to date with 'origin/3.2.x'.

You are currently cherry-picking commit 2113d28.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   forms/mainwindow.ui
	modified:   src/qt/mainwindow.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/eprosimashapesdemo/qt/mainwindow.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 2113d28 has failed:

On branch mergify/bp/2.14.x/pr-257
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 2113d28.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   forms/mainwindow.ui
	modified:   src/qt/mainwindow.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/eprosimashapesdemo/qt/mainwindow.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants