Skip to content

feat: add config to ignore certificate errors#55

Open
robed wants to merge 3 commits intoeWert-Online:masterfrom
robed:ignore-certificate-errors
Open

feat: add config to ignore certificate errors#55
robed wants to merge 3 commits intoeWert-Online:masterfrom
robed:ignore-certificate-errors

Conversation

@robed
Copy link
Copy Markdown

@robed robed commented Feb 5, 2026

Thanks for this great tool @eWert-Online, I've found it really useful.

For a current project, we need to do some visual regression testing across some test sites that don't have valid SSL certificates, so having an option to ignore them is useful.

This PR introduces a new config option, ignoreCertificateErrors a boolean that defaults to false.

I'm completely new to OCaml so I welcome any feedback and understand if you would prefer not to include this new configuration.

@eWert-Online
Copy link
Copy Markdown
Owner

Hello @robed 🙂

Thank you for the contribution. I am absolutely in favor of having this option.

I would suggest to not set the ignore flag through the browser launcher, but through the Chrome Devtools Protocol instead. There seems to be an option for it: https://chromedevtools.github.io/devtools-protocol/tot/Security/#method-setIgnoreCertificateErrors

These "global flags" are currently being enabled in the OSnap_Browser_Target.ml.

Do you think you are able to implement it that way? If you need help, feel free to reach out!

@robed
Copy link
Copy Markdown
Author

robed commented Mar 12, 2026

@eWert-Online Sorry it's taken me a while to get back to this.

I've updated the PR as you've suggested (although I've had to rely on Claude heavily for this!). I've done some testing and it appears to work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants