feat: add config to ignore certificate errors#55
Open
robed wants to merge 3 commits intoeWert-Online:masterfrom
Open
feat: add config to ignore certificate errors#55robed wants to merge 3 commits intoeWert-Online:masterfrom
robed wants to merge 3 commits intoeWert-Online:masterfrom
Conversation
Owner
|
Hello @robed 🙂 Thank you for the contribution. I am absolutely in favor of having this option. I would suggest to not set the ignore flag through the browser launcher, but through the Chrome Devtools Protocol instead. There seems to be an option for it: https://chromedevtools.github.io/devtools-protocol/tot/Security/#method-setIgnoreCertificateErrors These "global flags" are currently being enabled in the OSnap_Browser_Target.ml. Do you think you are able to implement it that way? If you need help, feel free to reach out! |
added 2 commits
March 12, 2026 16:32
Author
|
@eWert-Online Sorry it's taken me a while to get back to this. I've updated the PR as you've suggested (although I've had to rely on Claude heavily for this!). I've done some testing and it appears to work as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great tool @eWert-Online, I've found it really useful.
For a current project, we need to do some visual regression testing across some test sites that don't have valid SSL certificates, so having an option to ignore them is useful.
This PR introduces a new config option,
ignoreCertificateErrorsa boolean that defaults tofalse.I'm completely new to OCaml so I welcome any feedback and understand if you would prefer not to include this new configuration.