[bugfix] fixes potential NPE#6499
Merged
Merged
Conversation
duncdrum
approved these changes
Jun 19, 2026
line-o
reviewed
Jun 19, 2026
| case AtomicValue atomicValue -> value = atomicValue; | ||
| case InputSource source -> inputSource = source; | ||
| case byte[] bytes -> content = new String(bytes, UTF_8); | ||
| default -> content = obj.toString(); |
Member
There was a problem hiding this comment.
Why did you choose not to handle the null case within the switch?
Member
Author
There was a problem hiding this comment.
This will produce a codacy issue as the content is already set to null
Member
There was a problem hiding this comment.
Then I would prefer an early return
if (obj == null) { return; }
Member
There was a problem hiding this comment.
a noop would be another alternative
case null -> noop();
default -> content = obj.toString();
Signed-off-by: Patrick Reinhart <patrick@reini.net>
line-o
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a NPE when
nullis passed intosetContent(Object)