[chore] Switch to SPDX license headers#94
Merged
Conversation
duncdrum
reviewed
May 18, 2026
Contributor
There was a problem hiding this comment.
these headers on the templates files always crack me up…. what does that even mean
duncdrum
reviewed
May 18, 2026
duncdrum
left a comment
duncdrum
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the test failures are unrelated.
3 tasks
3 tasks
joewiz
added a commit
to joewiz/crypto-exist-java-lib
that referenced
this pull request
May 19, 2026
Same one-time fix as in eXist-db#93 / eXist-db#94 — GitHub disabled actions/cache@v2 in May 2026, breaking every push on the legacy workflow; and Maven 3.8.1+ blocks the http:// repository URLs that exist-apps-parent 1.11.0 still declares. When eXist-db#93 lands this commit drops cleanly on rebase. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
[This response was co-authored with Claude Code. -Joe] CI status update:
If the CI red is concerning, #95 cleans up the test suite end-to-end (46/46 green). #94, #95, #93 should land together to leave the repo in a fully-green state. |
4 tasks
joewiz
added a commit
to joewiz/crypto-exist-java-lib
that referenced
this pull request
May 19, 2026
Same one-time fix as in eXist-db#93 / eXist-db#94 / eXist-db#97 — when this PR rebases onto post-eXist-db#93 main, this commit drops cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
Replace the 17-line LGPL-2.1 boilerplate in every source file with a 2-line SPDX header, matching the pattern adopted by eXist-db/monex#323. Copyright lines are preserved exactly: most files keep "Copyright (C) 2016 Claudius Teodorescu"; pom.xml and CryptoIT.java keep "Copyright (C) 2016 The eXist-db Authors". Implementation: - LGPL2.1-template.txt -> two concrete templates (one per copyright holder) so license:check can match without property substitution - license-maven-plugin: switched to strictCheck=true now that the templates and file headers are exact matches Verified with `mvn -B license:check` and `mvn -B compile` on Java 21. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joewiz
added a commit
to joewiz/crypto-exist-java-lib
that referenced
this pull request
May 20, 2026
- SecureXmlParsers.java: switch to the SPDX 2-line header introduced in eXist-db#94 (per @line-o, @duncdrum). New file, so eXist-db Authors copyright; pom.xml updated to include it in the existdb licenseSet and exclude it from the Claudius one. - README: add a sentence noting the doctype gate is intentionally hardcoded for this conservative hardening round, and that opt-out follow-ups (e.g. an extra parameter or module toggle) for callers who legitimately need to validate signed docs with a DOCTYPE declaration would be welcome (per @duncdrum). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This response was co-authored with Claude Code. -Joe]
Per @line-o's request on #91, switch to SPDX-style license headers following the pattern adopted by eXist-db/monex#323.
Summary
Copyright (C) 2016 Claudius Teodorescu;pom.xmlandCryptoIT.javakeepCopyright (C) 2016 The eXist-db Authors. No attribution change.Implementation
The legacy template used
${organization}property substitution to share one boilerplate file across two<licenseSet>blocks. With the short SPDX form, that indirection caused the license plugin's strict-match to misfire. Replaced with two concrete templates (LGPL2.1-claudius-template.txt,LGPL2.1-existdb-template.txt), one per copyright holder — clearer and machine-checkable.Also flipped
strictCheckfromfalsetotruenow that templates and file headers match exactly (the plugin had been warning about this for years).Test plan
mvn -B license:checkpasses withstrictCheck=truemvn -B compilesucceeds on Java 21main, notexist-7-compat, so it inherits the pre-[compat] Build against eXist 7.0.0-SNAPSHOT (develop HEAD) #93 test-suite state)Coordination
This branches from
main, not fromexist-7-compat(#93). Whichever lands first, the other should rebase. The two PRs touch independent files except forpom.xml— that conflict is mechanical.