Mingxuanwupnnl/eamxx mam microphys for mamxx #347
Conversation
| Real invariants_k[nfs]; | ||
| View1D vmr_k = Kokkos::subview(vmr, k, Kokkos::ALL()); | ||
| View1D cnst_offline_k = Kokkos::subview(cnst_offline, k, Kokkos::ALL()); | ||
| Real h2ovmr_k = conversions::vmr_from_mmr(qv_k, mwh2o); |
There was a problem hiding this comment.
@mingxuanwupnnl @singhbalwinder . This line of code could change the values of this routine because of the mwh2o values in Haero versus E3SM.
There was a problem hiding this comment.
Are the values similar enough?
There was a problem hiding this comment.
I found the issue. I did not realize that setinv (column version) uses qv (mass mixing ratio of H2O) instead of vmr_h2o. The test is now passing with the previous error threshold.
2. Add a function to compute the length of work length arrays in photo_table: get_photo_table_work_len.
3. Add a function to set the view of PhotoTableWorkArrays: set_photo_table_work_arrays.
…ould be put together with surface emissions
… they should be put together with surface emissions" This reverts commit e5b1a2b. Conflicts: src/mam4xx/gas_chem.hpp
…he setinv_test_nlev test.
odiazib
force-pushed
the
mingxuanwupnnl/eamxx_mam_microphys_for_mamxx
branch
from
1b865e0 to
c1e4761
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 43 43
Lines 9486 9490 +4
=======================================
+ Hits 9122 9126 +4
Misses 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.